From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build Date: Fri, 17 May 2019 14:43:54 +0300 Message-ID: <83ftpdb91h.fsf@gnu.org> References: <83tvdtbimw.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="32078"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 17 13:44:47 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hRbI7-0008Dv-CY for ged-emacs-devel@m.gmane.org; Fri, 17 May 2019 13:44:47 +0200 Original-Received: from localhost ([127.0.0.1]:47088 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRbI6-0001jn-DG for ged-emacs-devel@m.gmane.org; Fri, 17 May 2019 07:44:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38876) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRbHX-0001hs-DZ for emacs-devel@gnu.org; Fri, 17 May 2019 07:44:12 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50436) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRbHV-0001GA-Ha; Fri, 17 May 2019 07:44:09 -0400 Original-Received: from [176.228.60.248] (port=4606 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hRbHQ-0002wz-Jh; Fri, 17 May 2019 07:44:07 -0400 In-reply-to: (message from Lars Ingebrigtsen on Fri, 17 May 2019 12:24:40 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236652 Archived-At: > From: Lars Ingebrigtsen > Cc: emacs-devel@gnu.org > Date: Fri, 17 May 2019 12:24:40 +0200 > > > Yes, it's called string-make-unibyte ;-) > > > > I'm not sure we have anything else, but let me dwell on this for a > > while. > > Ok. :-) > > > Btw, your other change in select.el was incorrect, and I reverted it. > > For starters, when we need to _decode_ text (which is what > > gui-get-selection does, since it imports text into Emacs), it can > > never be TRT to _encode_ it. > > Oh, sorry; thinko. > > > In general (with the possible exception of Gnus ;-), the places where > > we left those string-make/to/as-uni/multibyte thingies are there not > > because we were lazy, but because the replacements are either not > > trivial or don't exist. > > Right. Should we slap a with-no-warnings around this call, then? Maybe, but let me dwell on that as well. > > The deprecation message's advice in most of > > these cases is simply misleading. So I welcome work on these places, > > but my advice is to discuss each one of them before making changes, > > lest we break the code in some more or less subtle use cases. > > Will do. Thanks.