unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: eric@ericabrahamsen.net, emacs-devel@gnu.org
Subject: Re: Understanding atomic window groups
Date: Sat, 25 May 2019 11:13:28 +0300	[thread overview]
Message-ID: <83ftp33qaf.fsf@gnu.org> (raw)
In-Reply-To: <171bed6b-96d6-0fa0-f4f4-b09cb72c7192@gmx.at> (message from martin rudalics on Sat, 25 May 2019 09:59:03 +0200)

> From: martin rudalics <rudalics@gmx.at>
> Date: Sat, 25 May 2019 09:59:03 +0200
> 
>  > This is really helpful, and I see that the docstring of `delete-window'
>  > actually mentions the case of atomic windows. I agree with Eli that
>  > maybe more documentation is in order. I feel like all the pieces are
>  > present (here and there), but there's no one place to get a full
>  > overview.
> 
> The "one place" should be section 28.18 of the Elisp manual.  If
> something is missing there, please complain right away.

AFAICT, that section lists the functions affected by atomic windows,
but doesn't tell what you said earlier:

> 'quit-window' calls 'window-deletable-p' before it tries to delete a
> window so it should never cause a "Root of atomic window is root
> window of its frame" error.  If it does cause an error we have a bug
> so maybe check again.
> 
> 'delete-window' OTOH will raise an error when the root of the atomic
> window is the root of the frame.  If you want to avoid that, typically
> because most of your users who type C-x 0 expect the selected window
> to disppear or those typing C-x 1 expect the selected window to become
> the single window of its frame despite of atomicity, you will have to
> adjust the behavior with the help of 'delete-window' and
> 'delete-other-windows' parameters for all involved windows.

> I'll now try to amend the manual entries for 'split-window',
> 'delete-window' and 'delete-other-windows' appropriately as Eli
> suggested.

It's up to you whether to describe the behavior with atomic windows
where the functions are described or where the atomic windows are
described.  In the latter case, the description of the functions
should have a cross-reference to the atomic-windows section.

Thanks.



  reply	other threads:[~2019-05-25  8:13 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-22 17:50 Understanding atomic window groups Eric Abrahamsen
2019-05-23  8:39 ` martin rudalics
2019-05-23 20:14   ` Eric Abrahamsen
2019-05-24  8:01     ` martin rudalics
2019-05-24  8:24       ` Eli Zaretskii
2019-05-24 21:32       ` Eric Abrahamsen
2019-05-25  7:59         ` martin rudalics
2019-05-25  8:13           ` Eli Zaretskii [this message]
2019-06-03  9:11             ` martin rudalics
2019-06-03 15:10               ` Eli Zaretskii
2019-05-25 16:26           ` Eric Abrahamsen
2019-05-25 17:54             ` Eric Abrahamsen
2019-06-03  9:13               ` martin rudalics
2019-06-03  9:12             ` martin rudalics
2019-06-03 21:03               ` Eric Abrahamsen
2019-06-04  8:20                 ` martin rudalics
2019-06-04 17:28                   ` Eric Abrahamsen
2019-06-11 21:07                   ` Eric Abrahamsen
2019-06-15  8:16                     ` martin rudalics
2019-06-15 15:47                       ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ftp33qaf.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=eric@ericabrahamsen.net \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).