From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: bat-mode: Inconsistent fontification. Consider using
 font-lock-function-name-face
Date: Mon, 09 Sep 2019 19:09:39 +0300
Message-ID: <83ftl530zg.fsf@gnu.org>
References: <cfa93f75-bf75-788a-f9f0-ef38d956c2db@secure.kjonigsen.net>
 <vz1y2yxwxsm.fsf@gmail.com>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="104332"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: Andy Moreton <andrewjmoreton@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 09 18:18:21 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1i7MMt-000QwN-1F
	for ged-emacs-devel@m.gmane.org; Mon, 09 Sep 2019 18:18:19 +0200
Original-Received: from localhost ([::1]:58802 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1i7MMr-0001uJ-TC
	for ged-emacs-devel@m.gmane.org; Mon, 09 Sep 2019 12:18:17 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33395)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>) id 1i7MER-0002fc-IQ
 for emacs-devel@gnu.org; Mon, 09 Sep 2019 12:09:36 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37942)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
 id 1i7MEQ-0000Qm-Ss; Mon, 09 Sep 2019 12:09:35 -0400
Original-Received: from [176.228.60.248] (port=4477 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1i7MEQ-00066S-8x; Mon, 09 Sep 2019 12:09:34 -0400
In-reply-to: <vz1y2yxwxsm.fsf@gmail.com> (message from Andy Moreton on Mon, 09
 Sep 2019 11:48:09 +0100)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:239956
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/239956>

> From: Andy Moreton <andrewjmoreton@gmail.com>
> Date: Mon, 09 Sep 2019 11:48:09 +0100
> 
> > My proposal is that we change both these rules to instead be
> > font-lock-function-name-face. This solves both constency-problems:
> 
> That is not consistent with c-mode, which uses font-lock-constant-face
> for both goto statements and labels.

That's my feeling as well.  We fontify labels with
font-lock-constant-face in other programming modes, so it would feel
wrong to deviate from that in bat-mode.

As for uses of labels, I see your point about inconsistency, but maybe
this is justified due to the fact that batch-file labels can be
CALLed?