From: Eli Zaretskii <eliz@gnu.org>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: rudalics@gmx.at, emacs-devel@gnu.org
Subject: Re: simplifying windmove-frame-edges
Date: Fri, 25 Oct 2019 16:42:52 +0300 [thread overview]
Message-ID: <83ftjhvt43.fsf@gnu.org> (raw)
In-Reply-To: <CAAeL0STXt7hn4-Ciqmy39SH8q6jTtoS_Gq0a2z50rm16f_7MAQ@mail.gmail.com> (message from Juanma Barranquero on Fri, 25 Oct 2019 15:13:45 +0200)
> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Fri, 25 Oct 2019 15:13:45 +0200
> Cc: martin rudalics <rudalics@gmx.at>, Emacs developers <emacs-devel@gnu.org>
>
> > Are these comments really no longer relevant?
>
> They are relevant for the obsolete code, but they are misleading because they describe an implementation
> that's no longer used.
>
> I don't think we want to spend time fixing these functions, or any bugs in them, and we don't want to
> encourage *more* unbundled packages or user code using these functions. It's better to strip the comment,
> put a notice, and let it be until we feel it's safe to just remove it all.
So you are saying that nothing in those comments is relevant for the
implementation of non-obsolete functions? IOW, no reasonable amount
of changes in the comments will ever yield anything useful for the
code we now consider the mainstream? If so, then yes, removing those
comments is TRT.
Thanks.
next prev parent reply other threads:[~2019-10-25 13:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 11:54 simplifying windmove-frame-edges Juanma Barranquero
2019-10-23 16:05 ` martin rudalics
2019-10-23 18:10 ` Juanma Barranquero
2019-10-24 6:44 ` martin rudalics
2019-10-24 14:11 ` Eli Zaretskii
2019-10-25 12:17 ` Juanma Barranquero
2019-10-25 12:51 ` Eli Zaretskii
2019-10-25 13:13 ` Juanma Barranquero
2019-10-25 13:42 ` Eli Zaretskii [this message]
2019-10-25 14:05 ` Juanma Barranquero
2019-10-24 9:12 ` Phil Sainty
2019-10-24 9:37 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ftjhvt43.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).