From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Extend gdb to filter registers Date: Sat, 18 Jan 2020 20:48:07 +0200 Message-ID: <83ftgczjmg.fsf@gnu.org> References: <878spmuerf.fsf@mail.linkov.net> <83wod3bx8i.fsf@gnu.org> <9f5ddaa5-0234-a17b-bdd7-81d70a0a50d6@gmx.at> <83FFF194-64CD-409E-8B7A-5A9DF91E79DE@gmail.com> <83v9pb314t.fsf@gnu.org> <838sm510d6.fsf@gnu.org> <83muakzoy5.fsf@gnu.org> <71042c9f-478b-47c8-f27e-1348e9f4536d@gmx.at> <83iml8zkbm.fsf@gnu.org> <81EDE05A-43FA-4A1C-8C75-77CE541AD733@gmail.com> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="97408"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rudalics@gmx.at, juri@linkov.net, emacs-devel@gnu.org, monnier@iro.umontreal.ca, john@yates-sheets.org To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 18 19:48:49 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ist9M-000PFx-Ab for ged-emacs-devel@m.gmane-mx.org; Sat, 18 Jan 2020 19:48:48 +0100 Original-Received: from localhost ([::1]:43648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ist9L-00039u-D5 for ged-emacs-devel@m.gmane-mx.org; Sat, 18 Jan 2020 13:48:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45764) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ist8r-0002jT-R0 for emacs-devel@gnu.org; Sat, 18 Jan 2020 13:48:18 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56839) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ist8q-0007d7-Iu; Sat, 18 Jan 2020 13:48:16 -0500 Original-Received: from [176.228.60.248] (port=1234 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ist8l-0004CL-Ko; Sat, 18 Jan 2020 13:48:12 -0500 In-reply-to: <81EDE05A-43FA-4A1C-8C75-77CE541AD733@gmail.com> (message from Yuan Fu on Sat, 18 Jan 2020 13:36:34 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:244351 Archived-At: > From: Yuan Fu > Date: Sat, 18 Jan 2020 13:36:34 -0500 > Cc: martin rudalics , > john@yates-sheets.org, > emacs-devel@gnu.org, > monnier@iro.umontreal.ca, > juri@linkov.net > > The problem is in gud.el: it uses display-buffer instead of gdb-display-source-buffer. When you step, `gud-display-line` runs and calls display-buffer. My patch makes it use `gdb-display-source-buffer`. If the problem is in gud.el, then we must think about the other users of that code, like "M-x gud-gdb". gdb-display-source-buffer is specific to gdb-mi.el. And I see that as part of your patch you've removed the test of gud-minor-mode being gdbmi, which is probably not TRT. Also, what happens if the function into which you step is already displayed in some other window?