From: Eli Zaretskii <eliz@gnu.org>
To: Naoya Yamashita <conao3@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] * src/eval.c: Stop checking for nvars, and use only CONSP
Date: Tue, 02 Mar 2021 07:41:44 +0200 [thread overview]
Message-ID: <83ft1e6rjb.fsf@gnu.org> (raw)
In-Reply-To: <20210302.111043.609653289571449353.conao3@gmail.com> (message from Naoya Yamashita on Tue, 02 Mar 2021 11:10:43 +0900 (JST))
> Date: Tue, 02 Mar 2021 11:10:43 +0900 (JST)
> From: Naoya Yamashita <conao3@gmail.com>
>
> I found src/eval.c (let) has redundant conditions, that compares
> the length of the list with the current index and also checks if
> the current list is cons.
They aren't redundant, they were added to avoid crashes in certain
rare use cases. See commit 93511e9 and the emacs-devel discussion
which the log message refers to. If the problems described there are
no longer pertinent, can you explain why? TIA.
P.S. When I see code in Emacs that looks wrong/redundant/unclear, I
find it useful to look at the VC history of that code. This is how I
discovered where this particular "redundancy" came from, just 3.5
years ago.
next prev parent reply other threads:[~2021-03-02 5:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 2:10 [PATCH] * src/eval.c: Stop checking for nvars, and use only CONSP Naoya Yamashita
2021-03-02 2:48 ` Stefan Monnier
2021-03-02 3:09 ` Naoya Yamashita
2021-03-02 14:31 ` Stefan Monnier
2021-03-02 15:19 ` Pip Cet
2021-03-02 15:48 ` Stefan Monnier
2021-03-02 17:04 ` Pip Cet
2021-03-02 17:44 ` Stefan Monnier
2021-03-02 19:50 ` Pip Cet
2021-03-02 23:48 ` Stefan Monnier
2021-03-02 5:34 ` Pip Cet
2021-03-02 5:41 ` Eli Zaretskii [this message]
2021-03-02 7:14 ` Naoya Yamashita
2021-03-02 7:30 ` Pip Cet
2021-03-02 14:00 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ft1e6rjb.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=conao3@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).