From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 6) Date: Thu, 13 May 2021 13:32:47 +0300 Message-ID: <83fsyq2ab4.fsf@gnu.org> References: <0bbdeece-90d5-160c-07ec-2ad8edbf9872@daniel-mendler.de> <87czudm7bv.fsf@mail.linkov.net> <976056e8-3d46-db27-32c2-ddf3ca32d5a7@daniel-mendler.de> <878s5090e9.fsf@mail.linkov.net> <69fd42ed-a1a0-adcb-ac8b-caad80cb0967@daniel-mendler.de> <878s4zzpvc.fsf@mail.linkov.net> <95ac7ef3-5e8c-fc58-b316-544096c82aa0@daniel-mendler.de> <87o8dus00b.fsf@mail.linkov.net> <6718c89f-88a0-b529-1676-7e89fc152f00@daniel-mendler.de> <878s4w3law.fsf@mail.linkov.net> <87sg2ymq6j.fsf@mail.linkov.net> <87r1ifpyuc.fsf@mail.linkov.net> <83eeef7nzh.fsf@gnu.org> <87eeed2l0q.fsf@mail.linkov.net> <83o8dh3ybw.fsf@gnu.org> <854d8dbc-b64c-77e1-843b-95ac19e230e2@daniel-mendler.de> <83h7j93wjg.fsf@gnu.org> <83a6p13uux.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25810"; mail-complaints-to="usenet@ciao.gmane.io" Cc: juri@linkov.net, gregory@heytings.org, emacs-devel@gnu.org, monnier@iro.umontreal.ca, dgutov@yandex.ru To: Daniel Mendler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 13 12:34:04 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lh8fM-0006bv-6a for ged-emacs-devel@m.gmane-mx.org; Thu, 13 May 2021 12:34:04 +0200 Original-Received: from localhost ([::1]:44810 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lh8fL-0006x8-72 for ged-emacs-devel@m.gmane-mx.org; Thu, 13 May 2021 06:34:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34044) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lh8e5-0004vW-Eg for emacs-devel@gnu.org; Thu, 13 May 2021 06:32:46 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37052) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lh8e0-0002g4-D4; Thu, 13 May 2021 06:32:43 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4146 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lh8dy-0004ws-41; Thu, 13 May 2021 06:32:39 -0400 In-Reply-To: (message from Daniel Mendler on Tue, 11 May 2021 22:30:44 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269237 Archived-At: > Cc: gregory@heytings.org, dgutov@yandex.ru, emacs-devel@gnu.org, > monnier@iro.umontreal.ca, juri@linkov.net > From: Daniel Mendler > Date: Tue, 11 May 2021 22:30:44 +0200 > > > Then please consider my humble request to make this user-friendlier by > > offering simple Lisp values, not just functions. You and me can grasp > > 'identity or 'ignore with no trouble, but I'm not talking about you or > > me, or anyone else of the respected group mentioned above. This > > feature is not just for us. > > I attached the updated patches, the variable `completions-group-sort` > allows the more user friendly values nil and 'alphabetical. I hope it is > more acceptable in this form. Thanks, this addresses my concerns. (Please proofread the comments, doc strings, and Texinfo changes in the patches to make sure you leave 2 spaces between sentences, per our conventions to use US English.)