From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: macOS metal rendering engine in mac port Date: Sun, 30 May 2021 12:36:17 +0300 Message-ID: <83fsy44l7y.fsf@gnu.org> References: <83k0ni6pje.fsf@gnu.org> <83eedq6mvm.fsf@gnu.org> <83zgwd6gk3.fsf@gnu.org> <83bl8t5vu6.fsf@gnu.org> <83a6od5tqh.fsf@gnu.org> <834kel5qp3.fsf@gnu.org> <83zgwd489j.fsf@gnu.org> <83sg244tyk.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13171"; mail-complaints-to="usenet@ciao.gmane.io" Cc: alan@idiocy.org, emacs-devel@gnu.org To: Aaron Jensen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 30 11:37:03 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lnHsU-0003DF-PH for ged-emacs-devel@m.gmane-mx.org; Sun, 30 May 2021 11:37:02 +0200 Original-Received: from localhost ([::1]:60936 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lnHsT-0003D7-86 for ged-emacs-devel@m.gmane-mx.org; Sun, 30 May 2021 05:37:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47620) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lnHrf-0002X1-4B for emacs-devel@gnu.org; Sun, 30 May 2021 05:36:11 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36220) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lnHrd-00026Y-DA; Sun, 30 May 2021 05:36:09 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1688 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lnHrc-00082F-O9; Sun, 30 May 2021 05:36:09 -0400 In-Reply-To: (message from Aaron Jensen on Sun, 30 May 2021 00:04:43 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270120 Archived-At: > From: Aaron Jensen > Date: Sun, 30 May 2021 00:04:43 -0700 > Cc: Alan Third , emacs-devel@gnu.org > > If I run the test on line 499 of xdisp.c I get: > > Native, hash, no line numbers: 3756ms > Native, hash, line numbers: 4185ms > > Native, alist, no line numbers: 4810ms > Native, alist, line numbers: 7173ms In an unoptimized build, "emacs -Q", without native-compilation, I get 26.39 and 27.22 sec, respectively. > On line 500 of xdisp.c, less than 100 with line numbers off, ~1300 > with line numbers on. > I have 48 lines visible, a mode line with nothing in it, and a header line. > > If I disable my theme, I get about 9 moving to the right and 2 to the > left with line numbers on. Yikes. Indeed. > It's not my faces though, it's my header line that's causing that many > calls, possibly because it's triggering a redraw because the column > changed? I'm not sure how mode/header lines work when they update. You have the column displayed on your header-line? > Theme on: 7173ms > Header line off: 6900ms > Faces default: 6100ms > Header off and faces default: 5682ms > > For comparison, header off and faces default with line numbers off: 3804ms > > This does tell me I want to stop using inheritance in my theme, but it > won't make as big of a difference w/ the hash patch I imagine. Yes, which is why we want that patch, as soon as it's ready.