From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] Add switches for Git log command
Date: Tue, 08 Jun 2021 14:27:07 +0300
Message-ID: <83fsxsfvg4.fsf@gnu.org>
References: <87k0nej78o.fsf@gmail.com>
 <7ddd9a69-d1ff-132f-66ed-a9b5526d2ce7@yandex.ru>
 <871r9eqpej.fsf@gmail.com> <8335tthmox.fsf@gnu.org> <875yypazji.fsf@gmail.com>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="27401"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org, dgutov@yandex.ru
To: Utkarsh Singh <utkarsh190601@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jun 08 13:41:05 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1lqa6S-0006zb-Ef
	for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Jun 2021 13:41:04 +0200
Original-Received: from localhost ([::1]:54598 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1lqa6R-0007gQ-Dw
	for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Jun 2021 07:41:03 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44578)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1lqZtI-0006ZW-3V
 for emacs-devel@gnu.org; Tue, 08 Jun 2021 07:27:28 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58690)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1lqZtH-0001pp-Kh; Tue, 08 Jun 2021 07:27:27 -0400
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3062
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1lqZtH-0000dO-1L; Tue, 08 Jun 2021 07:27:27 -0400
In-Reply-To: <875yypazji.fsf@gmail.com> (message from Utkarsh Singh on Tue, 08
 Jun 2021 07:27:37 +0530)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:270560
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/270560>

> From: Utkarsh Singh <utkarsh190601@gmail.com>
> Cc: dgutov@yandex.ru, emacs-devel@gnu.org
> Date: Tue, 08 Jun 2021 07:27:37 +0530
> 
> > New or changed defcustoms should have a :version tag.
> 
> Done.

Thanks.

> +---
> +*** New user option 'vc-git-log-switches'.
> +Strings or list of strings specifying switches for Git log under VC.
   ^^^^^^^
This should be "String", singular, right?

Otherwise LGTM.