From: Eli Zaretskii <eliz@gnu.org>
To: Gregory Heytings <gregory@heytings.org>
Cc: larsi@gnus.org, monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: emacs.pdmp not always rebuilt
Date: Mon, 04 Oct 2021 15:50:16 +0300 [thread overview]
Message-ID: <83fsth6jjr.fsf@gnu.org> (raw)
In-Reply-To: <6c69780538e7dcf21be8@heytings.org> (message from Gregory Heytings on Mon, 04 Oct 2021 08:57:04 +0000)
> Date: Mon, 04 Oct 2021 08:57:04 +0000
> From: Gregory Heytings <gregory@heytings.org>
> cc: larsi@gnus.org, monnier@iro.umontreal.ca, emacs-devel@gnu.org
>
> >> This is because of dcf9cd47ae. Patch attached, which will hopefully
> >> fix the other silent failures you experience.
> >
> > Thanks, but why condition that on batch mode? Does the problem happen
> > in any batch-mode invocation, and if so, why?
>
> When Emacs has been built, the problem does not seem to exist anymore.
> FWIW, I'm not sure it makes sense to call substitute-command-keys there,
> even in non-batch mode, but it should probably be okay to limit the scope
> of the fix to something narrower. Updated patch attached, this time
> against the current trunk.
But what is the underlying problem? Is it perhaps that
substitute-command-keys is defined in help.el, and help.el is loaded
by loadup only after simple.el? If so, I think there could be a
better solution to this: either change the order of loading, or simply
test if substitute-command-keys is fboundp, and avoid using it if not.
next prev parent reply other threads:[~2021-10-04 12:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 12:41 emacs.pdmp not always rebuilt Lars Ingebrigtsen
2021-10-03 12:53 ` Eli Zaretskii
2021-10-03 13:10 ` Lars Ingebrigtsen
2021-10-03 14:35 ` Stefan Monnier
2021-10-03 14:38 ` Lars Ingebrigtsen
2021-10-03 23:27 ` Gregory Heytings
2021-10-04 0:45 ` Stefan Kangas
2021-10-04 2:28 ` Eli Zaretskii
2021-10-04 8:57 ` Gregory Heytings
2021-10-04 9:19 ` Lars Ingebrigtsen
2021-10-04 11:14 ` Stefan Kangas
2021-10-04 12:53 ` Eli Zaretskii
2021-10-04 12:50 ` Eli Zaretskii [this message]
2021-10-04 13:05 ` Gregory Heytings
2021-10-04 13:25 ` Gregory Heytings
2021-10-04 13:37 ` Eli Zaretskii
2021-10-04 14:18 ` Gregory Heytings
2021-10-04 14:34 ` Eli Zaretskii
2021-10-04 16:02 ` Gregory Heytings
2021-10-04 16:56 ` Eli Zaretskii
2021-10-04 13:30 ` Eli Zaretskii
2021-10-04 14:03 ` Stefan Kangas
2021-10-04 14:19 ` Gregory Heytings
2021-10-04 15:10 ` Eli Zaretskii
2021-10-03 14:52 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fsth6jjr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=gregory@heytings.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).