From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 5b5608c614: Fix glyph skipping optimization when a tab line is enabled Date: Mon, 18 Apr 2022 12:18:58 +0300 Message-ID: <83fsmawxz1.fsf@gnu.org> References: <83k0bmx3ke.fsf@gnu.org> <87bkwykfs5.fsf@yahoo.com> <83ilr6x2gx.fsf@gnu.org> <8735iaket0.fsf@yahoo.com> <83h76qx0t0.fsf@gnu.org> <87mtgiiyux.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2305"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 18 11:23:35 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ngNbZ-0000RO-Ex for ged-emacs-devel@m.gmane-mx.org; Mon, 18 Apr 2022 11:23:33 +0200 Original-Received: from localhost ([::1]:48714 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ngNbY-0006gb-0L for ged-emacs-devel@m.gmane-mx.org; Mon, 18 Apr 2022 05:23:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43572) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngNXh-0004Ag-5U for emacs-devel@gnu.org; Mon, 18 Apr 2022 05:19:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40432) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngNXf-00058P-K8; Mon, 18 Apr 2022 05:19:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=kYk2IA8x3/L7ICqGChRu1mAP0Jr8A+scmiwXbrIaifM=; b=ONYjt8sIQJ7d AhLJVevVdYvGXWhCfQ7mbLV7mo7+hl62FptFj8wjrOUjJDd5Btiu+SdAH1i9i0BfNeVFtmt7Fn1Yo oIoTlAauHDAVDuNAltgxmpOc/UL43Dqa26V+KZCYFiEHwmDPaXtHvHAgeagB0onO+E0zxspe2zfAo t+zr14GOdqhe8zgFouClAz/FOUD7VREwqKY1cUwbHnqe7fS1PyZ3+SH6Z+F3JFPe2x9za43koEzbm JFq7TDw3eF8GjTukotxU93iMflwGlmUooaxwnShy77ZGorYA4tLJTRPhYALsZGBsAQFl/9rNg6aM0 Zqf1mFUxQstrXvo7JRgBAw==; Original-Received: from [87.69.77.57] (port=3646 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngNXK-0000Xe-Ig; Mon, 18 Apr 2022 05:19:20 -0400 In-Reply-To: <87mtgiiyux.fsf@yahoo.com> (message from Po Lu on Mon, 18 Apr 2022 16:23:34 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288617 Archived-At: > From: Po Lu > Cc: emacs-devel@gnu.org > Date: Mon, 18 Apr 2022 16:23:34 +0800 > > Eli Zaretskii writes: > > > Maybe not, but why should such subtle assumptions be implicitly > > embedded in the code, when you have specific flags to do the job? A > > glyph matrix has both header_line_p and tab_line_p flags, so comparing > > to their sum should do the job cleanly, I think. > > Yes, I already installed such a change, but I asked that question for > future reference. I think the answer is YES, but the condition is enforced in window.el, so it isn't necessarily "carved in stone".