From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: master 0da97d6: * src/keyboard.c (timer_check_2): Replace
 redundant test with assertion
Date: Fri, 05 Aug 2022 21:20:09 +0300
Message-ID: <83fsiazh5y.fsf@gnu.org>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="14113"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: Stefan Monnier <monnier@iro.umontreal.ca>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Aug 05 20:21:19 2022
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1oK1wk-0003XN-CE
	for ged-emacs-devel@m.gmane-mx.org; Fri, 05 Aug 2022 20:21:18 +0200
Original-Received: from localhost ([::1]:37318 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1oK1wj-0007t1-D6
	for ged-emacs-devel@m.gmane-mx.org; Fri, 05 Aug 2022 14:21:17 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46338)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1oK1vn-0007Aj-5G
 for emacs-devel@gnu.org; Fri, 05 Aug 2022 14:20:19 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42998)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1oK1vm-0006fq-Si; Fri, 05 Aug 2022 14:20:18 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=Subject:To:From:Date:mime-version:in-reply-to:
 references; bh=TkYdlxmMH11euCZqDr3LB0PgJUpsHFfSACKkodZmR2c=; b=p1GpPlHcaP8IY5
 p4OC9amxtQ714L8BZu6ZtzBrJhaKAl148OtpeHmIBSOeeUHhUeuNMhP3ZSjXrn5gc0FbSQBOOTbQd
 Jg/V43iSJRjw51w0e3Nisa2BZifx1qJn0hmZLnIVrpaQMSYoKhKfT1uOPGIsGavJx1u7nZx5HZvGL
 ybhw+KIChvx9c1ekv51tYn+eiYVLL2BND1LWNwolXLyYZFJOK9UoUJ51VBCAJ2aEuusfspeHZl+yx
 hB5/srMDm6a5F2qOqsa4PestkkjvGDSyiJFZUehU38dGo2fWJDV7flIMDfSIOZhCJWUEV2KUpo2wB
 V1g4pF+ClYolTf9ljMhQ==;
Original-Received: from [87.69.77.57] (port=1384 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1oK1vc-0006D5-Hd; Fri, 05 Aug 2022 14:20:18 -0400
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:293124
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/293124>

IMNSHO, this change is dangerous: it replaces run-time conditions with
assertions, but IME most if not all of the active developers and
people who track the master branch don't compile with --enable-checking,
or don't run the trunk build on a regular basis.  Which means these
assertions, if they happen, will not be seen nor reported.

So basically you removed a safety net without any replacement.

I suggest to revert this change.  It gains us nothing of importance.