From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349) Date: Mon, 29 Aug 2022 19:46:40 +0300 Message-ID: <83fshfvvyn.fsf@gnu.org> References: <166171593185.16640.41619657947456727@vcs2.savannah.gnu.org> <20220828194533.23A6BC00889@vcs2.savannah.gnu.org> <87r10znm0y.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34357"; mail-complaints-to="usenet@ciao.gmane.io" Cc: juri@jurta.org, emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 29 18:48:36 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oShwC-0008lt-HC for ged-emacs-devel@m.gmane-mx.org; Mon, 29 Aug 2022 18:48:36 +0200 Original-Received: from localhost ([::1]:33690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oShwB-0006dn-Gt for ged-emacs-devel@m.gmane-mx.org; Mon, 29 Aug 2022 12:48:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40588) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oShu2-0005Cp-0l for emacs-devel@gnu.org; Mon, 29 Aug 2022 12:46:24 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42546) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oShu1-0006oP-G4; Mon, 29 Aug 2022 12:46:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KyzWPLFO+H4kj7utBeDpmNYuOTw1Nxe46xlI3LTgTeM=; b=GnYBsslYjofM n+bVgAQm5ASf9/fYbGjlj2saGVjlBzR2/KS4VV7SnR1SWpIw7s74IvohBiNngkT8VV12UI/C1Q2Nw GUJ+aO0XOVimmh63ZZSBT+2iSwXOAMYZ37s872u7gRaMcOtVJyeJXONwpBUAQp2Jh6zffZfghddt/ 07M74mBKgFCLBOB+O3xfDt0eGfms/qhtnfrTPna9K5U+0DnIiJAhFuHOqdr7ontB7QA83I95mMIRc gvwDVXv608FTpv3OzxcJ/XT+1Ny+6M9Vj7ce+vMF1/q05BlRfaePGmMatJbmEBxwPrxMb2tP6xG1i LM+qKZGG6USLlSOfxNdweg==; Original-Received: from [87.69.77.57] (port=1067 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oShu0-0006Zj-Hp; Mon, 29 Aug 2022 12:46:21 -0400 In-Reply-To: <87r10znm0y.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 29 Aug 2022 16:48:29 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294289 Archived-At: > From: Lars Ingebrigtsen > Cc: emacs-devel@gnu.org > Date: Mon, 29 Aug 2022 16:48:29 +0200 > > Juri Linkov writes: > > > 'C-x v v' on a diff buffer commits it as a patch (bug#52349) > > Excellent! This is going to save me a lot of work in the future. Bother: This is only supported for Git, which is against the spirit of VC, and definitely against the spirit of "C-x v v". Why cannot this be implemented for every other VCS? Given diffs in a buffer, it should be as simple as running the Patch utility via shell-command-on-region, then committing the results. Git has a special command for that, but we don't need a special command for other VCSes, if they don't have the equivalent of "git apply". (I'm guessing that "git apply" simply runs Patch under the hood.) Can we please implement this for other VCSes as well?