From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Call for volunteers: add tree-sitter support to major modes Date: Mon, 10 Oct 2022 09:28:29 +0300 Message-ID: <83fsfwi44y.fsf@gnu.org> References: <83czb1jrm3.fsf@gnu.org> <84436B1D-3359-487F-B997-A7F56FDEA636@thornhill.no> <83bkqljih5.fsf@gnu.org> <87fsfx6ufb.fsf@thornhill.no> <8335bxjdpf.fsf@gnu.org> <1D07A0F1-A269-410A-9D3C-8A53113FFE2F@thornhill.no> <83sfjxhuvc.fsf@gnu.org> <87bkqk7qb0.fsf@thornhill.no> <8735bw7kwm.fsf@thornhill.no> <158F25C9-A539-4515-8D49-50A7E6252960@gmail.com> <9941E2A6-AB31-49FE-A6BA-9BE61BA6ED13@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12454"; mail-complaints-to="usenet@ciao.gmane.io" Cc: theo@thornhill.no, emacs-devel@gnu.org To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 10 08:31:50 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohmKM-00031u-1r for ged-emacs-devel@m.gmane-mx.org; Mon, 10 Oct 2022 08:31:50 +0200 Original-Received: from localhost ([::1]:43516 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohmKK-0007ha-Vo for ged-emacs-devel@m.gmane-mx.org; Mon, 10 Oct 2022 02:31:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36178) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohmHP-0005f2-2u for emacs-devel@gnu.org; Mon, 10 Oct 2022 02:28:47 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52864) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohmHO-000872-4Z; Mon, 10 Oct 2022 02:28:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=NAds4uIJIkL4kD9UclyPyLtNL2bgtkdpBdbCBQ/ZCLc=; b=pgJjd0KiDIyoI/HOOwN9 YRzfFAp8HfyxH0+QzN9ccv0bDXjHMN1YAjPEqr2MR+XBzgKRcGp5rUfSzRNhp1JqFjdLNZF2Egr+B BxaOJgOfUbuTz08winsjq5Q+BBJkRUEKxARXztiMY0dYElAJME8sKHU0qIrOS/C2/y8b5VYvjvNmH t0Cdni+PxOuFrdTWMfECQFKHPBJeyg8jB2IfDmK7f4PkJiCcugREkd3rfrdYMz0v46XrHLtwemopy p5D4k6S4nNKLpb/pnkCcNMB/bQyUPy1nksQvJGaY/cyBBcYvrF/uuVrZy+n03Xujkao+qkW2p6MkM VgHxqDyHov9j2A==; Original-Received: from [87.69.77.57] (port=3067 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohmH1-0005n9-N2; Mon, 10 Oct 2022 02:28:43 -0400 In-Reply-To: <9941E2A6-AB31-49FE-A6BA-9BE61BA6ED13@gmail.com> (message from Yuan Fu on Sun, 9 Oct 2022 21:05:09 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297311 Archived-At: > From: Yuan Fu > Date: Sun, 9 Oct 2022 21:05:09 -0700 > Cc: Eli Zaretskii , > emacs-devel@gnu.org > > > + > > +(defun js--treesit-enable () > > + (unless (and (treesit-can-enable-p) > > + (treesit-language-available-p 'javascript)) > > + (error "Tree sitter isn't available")) > > > > I don't think we should error here, I'd displaying a message instead. > > Actually we should also fall back to non-tree-sitter if the conditions aren’t met. Automatically and silently? I don't think so. The user should know the knob they pressed didn't work.