From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Tree sitter support for C-like languages Date: Sun, 13 Nov 2022 15:08:14 +0200 Message-ID: <83fsenknnl.fsf@gnu.org> References: <87tu36em9t.fsf@thornhill.no> <45FD2F78-F15B-488B-9348-A8E298D8AD35@gmail.com> <87v8nmyqqp.fsf@thornhill.no> <834jv4nz2g.fsf@gnu.org> <871qq8hsj1.fsf@thornhill.no> <83iljklzmo.fsf@gnu.org> <87v8nkgcqj.fsf@thornhill.no> <87sfiogcbm.fsf@thornhill.no> <83pmdrkyj7.fsf@gnu.org> <87v8njw5th.fsf@thornhill.no> <83leofkwjm.fsf@gnu.org> <963E740B-B9BA-49E3-A64E-501394DFE41A@thornhill.no> <83h6z3ko8l.fsf@gnu.org> <87r0y7nh21.fsf@thornhill.no> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4578"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, emacs-devel@gnu.org, monnier@iro.umontreal.ca To: Theodor Thornhill Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 13 14:08:31 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ouCir-00011w-Nd for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Nov 2022 14:08:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouCiW-0004HH-Sm; Sun, 13 Nov 2022 08:08:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouCiU-0004H7-Rc for emacs-devel@gnu.org; Sun, 13 Nov 2022 08:08:06 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouCiU-0000qz-2L; Sun, 13 Nov 2022 08:08:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Bz/waKPTF3uTN8xSpQeTzTlxpXybTJlK5CKDnDYv++I=; b=TgBvoPVmsyB3 xC0FIKQtCF96qLOh549MmZU/nIFzXYR7I73hK1w4YWcb0wtXejRf1BHOrmUtPNR3mUVtpzKxsNrSG 6lqIIjc6KPeUIojqEg2LBFJu86SUxdldndUspzNE033UaGwmPNJ/1GozAkOdwTtzbonWOcWa2ldZp d5WSkwed5i/+O3JX+RtwfnKk8xxz7gwHRhdni8NfkwoFcedOxsgVBAnxaUkS7rg/D4s2Y2G46h7cy fWCa4djWLAG9mofDu509Q7JYuGVB2uj6ib9DuutXS97g7Upsj3awiVXZ9rTh3Sv6/AAqaVWZbdk0G Sfj8x1VF2F6aGtU1jbLOcA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouCiT-0006F4-DU; Sun, 13 Nov 2022 08:08:05 -0500 In-Reply-To: <87r0y7nh21.fsf@thornhill.no> (message from Theodor Thornhill on Sun, 13 Nov 2022 14:02:30 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299721 Archived-At: > From: Theodor Thornhill > Cc: casouri@gmail.com, emacs-devel@gnu.org, monnier@iro.umontreal.ca > Date: Sun, 13 Nov 2022 14:02:30 +0100 > > Eli Zaretskii writes: > > >> Date: Sun, 13 Nov 2022 11:13:24 +0100 > >> From: Theodor Thornhill > >> CC: casouri@gmail.com, emacs-devel@gnu.org, monnier@iro.umontreal.ca > >> > >> >> I think the best solution is just to remove the > >> >> > >> >> ``` > >> >> :language mode > >> >> :override t > >> >> :feature 'error > >> >> '((ERROR) @font-lock-warning-face) > >> >> ``` > >> > > >> >What are the downsides of removing this? what will we lose? > >> > > >> > >> Absolutely nothing. Only the yellow color. > > > > Which yellow color? > > > > And if we lose nothing, why was this in the code to begin with? what > > was the thought behind using it? > > The warning face. My thinking was merely that identifying syntax errors > could be useful, but I now believe this causes more noise and confusion > rather than being a helpful tool. I'm not sure I agree. Having incomplete code show in a distinct color could be a nice feature, at least as an option. The problem is that the warning face doesn't go away when the code is completed, but I think this is a separate and different problem. > So there's no need to use it. These error-nodes can be seen with > 'treesit-inspect-mode' for those interested anyways. The inspect nod is for debugging TS-backed modes, not for editing program source. So it is not relevant to what bothers me. I think we should fix the problem with the warning face staying put, and then revisit the usefulness of the warning face.