From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Help with new Windows 98 crash Date: Tue, 06 Dec 2022 16:32:13 +0200 Message-ID: <83fsds7gcy.fsf@gnu.org> References: <87o7sindcl.fsf.ref@yahoo.com> <87o7sindcl.fsf@yahoo.com> <83ilip9a37.fsf@gnu.org> <838rjl9477.fsf@gnu.org> <87k035nwv3.fsf@yahoo.com> <83wn747mt5.fsf@gnu.org> <87r0xcn15q.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33008"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 06 15:33:23 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2Z0c-0008NL-Ov for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Dec 2022 15:33:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2Yzl-000707-9Q; Tue, 06 Dec 2022 09:32:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2Yzj-0006zM-Jv for emacs-devel@gnu.org; Tue, 06 Dec 2022 09:32:27 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2Yzj-00080F-Bi; Tue, 06 Dec 2022 09:32:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=EO2RfqU2BrHQVn9l1ZAqPhhKz5ttxwO0CM4ox7jjEo0=; b=Mj3Z6mhF31DN cvf7HLq1qKh8Ul9xH8sgT552jx7DZucKLKQEhut4OB3R+XbNKJPSD1x714y1TKROTtkKlxRXXSg25 8GfVKMd/JZIYiQZSQ9LftlQjIIG7Zkxf1kgdaAT4PNMeIJQP3di5Z32rGAxXCuCvhNe24Xw66jENh oQzUixm3ayGzQ5y3EL8eKKUQ6EWiQgKbxcjX3Ht5FZIKo5EKbquim7VdRDqbT2aiqhqUhY0shFqa1 Oo2vmoeAm2Mwg4Yy5Oq41aHpwli+hkOSrGODvWY5q6JF0pj/HnUHad0ZyipLFPhzrlAUTbpMNgaxg wOstFFZ5HD4mG2QBxTx/Uw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2Yzi-00031i-Qr; Tue, 06 Dec 2022 09:32:27 -0500 In-Reply-To: <87r0xcn15q.fsf@yahoo.com> (message from Po Lu on Tue, 06 Dec 2022 20:53:53 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300969 Archived-At: > From: Po Lu > Cc: emacs-devel@gnu.org > Date: Tue, 06 Dec 2022 20:53:53 +0800 > > Eli Zaretskii writes: > > > There's nothing unsafe in what you did, but: > > > > . the call to init_bignum inside the !initialized block should be > > conditioned on HAVE_UNEXEC > > But doesn't it have to come before init_window_once in any case? > Otherwise, the wrong malloc will be used even on pdumper builds. You mean, in the pdumper build? In that build, what init_bignum does is not dumped, so I don't think we need it. Otherwise, why didn't we see any problems until now? But if you want to call it in the pdumper build as well, I won't mind. Just let's make sure it is called only once upon each invocation.