From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Merging feature/android Date: Sat, 04 Mar 2023 09:20:35 +0200 Message-ID: <83fsalasos.fsf@gnu.org> References: <87edq7ztks.fsf.ref@yahoo.com> <87edq7ztks.fsf@yahoo.com> <83pm9reccn.fsf@gnu.org> <87v8jjxxo9.fsf@yahoo.com> <382933e4-deb5-e107-9165-d41e55949f0a@cs.ucla.edu> <87h6v1wfat.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24745"; mail-complaints-to="usenet@ciao.gmane.io" Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 04 08:22:01 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pYMDR-0006As-9Q for ged-emacs-devel@m.gmane-mx.org; Sat, 04 Mar 2023 08:22:01 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYMCO-0007WA-P3; Sat, 04 Mar 2023 02:20:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYMCI-0007Tf-9A for emacs-devel@gnu.org; Sat, 04 Mar 2023 02:20:50 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYMCH-0005Ej-CB; Sat, 04 Mar 2023 02:20:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=vRON5I3K470ODVVx8++TKQVFwHPFM3XPnDCf3X1tEmA=; b=Rrng21ToC6e8 DYZI3U4V+HJuZ7FB885QZm0hrOKFgPo246MeBZxwc/7/6qVdtjJjYoL6elMhK/yzuBMcvSLvf/Pa6 ZBj7CsbIBlwynE0Z2mzyO0DTrqlHs84zlOIMmZykYHGou8ccMlxsFTSWuCx4SAFEsZZFy5l35CpY7 r6jS4KSMRTNdSHRjOpPOiKF3SWbUvUc+4RprJCXk3oYwbrRys2cj9aBUJVZyDo9AcqOPIIoQLPeFN 9bbvhjdTaZwWjbxd9wIWk2fs0nsm61+RnA3fh8GEpjBTaJnam+G1/6YmpuiApAjk7PHkIaSCURaSx YReAlD2ahEojP0x40EbDlQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYMCG-0006sI-Jp; Sat, 04 Mar 2023 02:20:49 -0500 In-Reply-To: <87h6v1wfat.fsf@yahoo.com> (message from Po Lu on Sat, 04 Mar 2023 08:06:34 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303933 Archived-At: > From: Po Lu > Cc: Eli Zaretskii , emacs-devel@gnu.org > Date: Sat, 04 Mar 2023 08:06:34 +0800 > > Paul Eggert writes: > > > This should be doable by having two build directories, but only one > > copy of the Gnulib source should be needed. The two build directories > > would have different config.h files. You'd run 'configure' twice (or > > have two 'configure' files if you want to be fancier). That sort of > > thing. > > They do, yes, but the problem is the C compiler doesn't understand GNU > make vpath directives, so the includes in lib/ are: > > -I$(srcdir) -I. > > while the includes in cross/src/lib are: > > -I$(top_srcdir)/lib -I$(srcdir) -I. > > and as a result, when a file in -I$(top_srcdir)/lib then includes: > > #include "stdio.h" > > it gets the stdio.h in lib, and not cross/lib, leading to silent > problems later on. Can you perhaps use -isystem or -iquote or -dirafter compiler switches to work around these problems? Anyway, I think we should fix these issues before we land the branch. I'd really hate to have 2 copies of Gnulib files in the repository.