From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Merging feature/android Date: Thu, 09 Mar 2023 11:21:16 +0200 Message-ID: <83fsae2sc3.fsf@gnu.org> References: <87edq7ztks.fsf.ref@yahoo.com> <87y1obsamf.fsf@yahoo.com> <0100f288-fcc0-8b91-5f12-18bf22969e50@cs.ucla.edu> <87ttyzs8q1.fsf@yahoo.com> <253e9494-6f78-89b7-8f5f-9c2e8461d95a@cs.ucla.edu> <878rgaspvs.fsf@yahoo.com> <86bkl6z1sc.fsf@aarsen.me> <87mt4qqi2o.fsf@yahoo.com> <83a60q84eo.fsf@gnu.org> <87a60qqb0c.fsf@yahoo.com> <83y1oa6k71.fsf@gnu.org> <87sfehpfcv.fsf@yahoo.com> <83a60o7mif.fsf@gnu.org> <87jzzspvcl.fsf@yahoo.com> <83ttyw65v5.fsf@gnu.org> <4B15D851-5638-48E6-A789-3017A1CBA971@yahoo.com> <8584ff7c-f83e-18b1-1300-dfa0788e4443@cs.ucla.edu> <87v8jbohk4.fsf@yahoo.com> <831qlz5pas.fsf@gnu.org> <87356en2w7.fsf@yahoo.com> <83o7p22xq4.fsf@gnu.org> <875ybal55j.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23336"; mail-complaints-to="usenet@ciao.gmane.io" Cc: eggert@cs.ucla.edu, arsen@aarsen.me, emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 09 10:22:15 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1paCTW-0005tM-HI for ged-emacs-devel@m.gmane-mx.org; Thu, 09 Mar 2023 10:22:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1paCSh-0003Sx-RL; Thu, 09 Mar 2023 04:21:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paCSd-0003Ma-N2 for emacs-devel@gnu.org; Thu, 09 Mar 2023 04:21:22 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paCSb-0002Pf-He; Thu, 09 Mar 2023 04:21:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=XgwqNOeKgjOcZvBtf/riNeFRs9uxkm+Blk1TCVfJM7M=; b=hKFAUn+Zcybr p7jQSGiib5Snhwh2qiL3sSAs1wQdEtofkalRo1tosjJv6jKWrfrzgCP6TyEmKE3FFCbxonsRpbSUL L5XtBDx8hurDgspxL2WrEIYzom/YNbYbtkOo2NURwuAS3kQZ+XhEAbirQRrjHQ3q9TFJYsYg4ItiG A8zXL03zwCZGvkcAO3xRQZayY0adqEPtciFq+gTSSNs+LvYr4tWpIcr0RYNT0a6Y5+UUDQEIhnoD+ RAfOSMFL3isnc+KTfCpVRsCifx35JylBxdGU4KFNIy1QkwnYOzrdQEsbxxRj9g750lnwl4C04wbs0 pWKwlvvI74mp6t78LqKXAw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paCSb-0001tR-0a; Thu, 09 Mar 2023 04:21:17 -0500 In-Reply-To: <875ybal55j.fsf@yahoo.com> (message from Po Lu on Thu, 09 Mar 2023 16:07:04 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304173 Archived-At: > From: Po Lu > Cc: eggert@cs.ucla.edu, arsen@aarsen.me, emacs-devel@gnu.org > Date: Thu, 09 Mar 2023 16:07:04 +0800 > > Eli Zaretskii writes: > > > I disagree with your conclusion, and I still think we should complain > > noisily if modules cannot be supported. > > OK, but I still think this is a very bad idea. Do you object to > rewriting emacs-module.c to not utilize __attribute__ ((cleanup))? > > What was said earlier by some people is wrong: as-is, in Emacs, it makes > no difference whether or not we write: > > foo __attribute__ ((cleanup (module_reset_handlerlist)))... > > or: > > foo... > module_reset_handlerlist (foo); If you want to discuss this, please start a new thread and CC Daniel Colascione and Philipp Stephani, who I believe wrote that part of emacs-module.c. I don't think we should change that without a thorough discussion, as that code is quite old and I don't think it caused any trouble whatsoever.