From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Code quality of some -ts-mode major modes Date: Sat, 18 Mar 2023 07:59:12 +0200 Message-ID: <83fsa2d2hb.fsf@gnu.org> References: <87fsa3g05n.fsf@posteo.net> <87bkkrft9n.fsf@posteo.net> <83a60beb5a.fsf@gnu.org> <34e4a26f-3830-9b8c-a5e0-861a63f5f8bc@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31375"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, ruijie@netyu.xyz, casouri@gmail.com, emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 18 07:00:06 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pdPbp-0007xo-R7 for ged-emacs-devel@m.gmane-mx.org; Sat, 18 Mar 2023 07:00:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pdPb9-0001g1-9q; Sat, 18 Mar 2023 01:59:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdPaz-0001fU-27 for emacs-devel@gnu.org; Sat, 18 Mar 2023 01:59:14 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdPax-0004Tw-5U; Sat, 18 Mar 2023 01:59:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=GJnDyKzS8XngCmiApABY/2dax42O6nPrGuvWNblAJUw=; b=Vc2evSm2Jsx4 g9MU2ZkjFk72VFWcm4cl7unpyyBqv2K40d+A1AAOsWyGGEr0lDRAg+nScAgIgDSqA8fivPemvaAJt RqlTC0Khnd/oYnP5r1VoD28RfxeBKk0yodYsfjLvJSyUPwZRZTj9E9rHx6pXyHwHFSohRwGNEfx1Y TkR/pOMSWQL2dkMwrXXZG0qFZstb3GUP2e2FM5Z5xTaIF+N/Pp36ItZi7Guzydmg7L8X0Frfuvts8 mjwmJPSsVW/BN8GhoOSf/cHJXs1oQkQXrArpZSluKz05U96dN6/yD+WjJlGkIP9GlPU09s+gMjq2u l2YXmc66KjSGOiZVyJKLRg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdPav-0007qS-Jl; Sat, 18 Mar 2023 01:59:10 -0400 In-Reply-To: <34e4a26f-3830-9b8c-a5e0-861a63f5f8bc@yandex.ru> (message from Dmitry Gutov on Fri, 17 Mar 2023 23:45:00 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304562 Archived-At: > Date: Fri, 17 Mar 2023 23:45:00 +0200 > Cc: ruijie@netyu.xyz, casouri@gmail.com, emacs-devel@gnu.org > From: Dmitry Gutov > > On 17/03/2023 15:54, Eli Zaretskii wrote: > >> I repeat my question from above, if we are ready to link to the > >> grammars, wouldn't it make sense to populate the variable > >> `treesit-language-source-alist' directly? > > No, I don't want to do that, see above for the reasons. (We had this > > discussion about 2 months ago, when the command was added to Emacs.) > > FWIW, I had no problems with that conclusion, but then I noticed that we > keep a separate list of sources inside admin/notes/tree-sitter, which > basically contains the same info, as well as all 6 known exceptions to > the general scenario (where in the usual case we can determine > everything just from the name of the language). > > If we're going to keep it updated (and we apparently are), why not move > that info to treesit-language-source-alist instead. My original plan was to remove that script from admin/notes before releasing Emacs 29. I decided to wait for a while, but I definitely don't want to commit ourselves to maintaining the script in the future versions. The information is just one Internet search away, usually the first hit is the one you want. More generally, the tree-sitter stuff seems to be just starting to get noticed by distros, and it is too early to make any firm decisions related to availability of information and libraries. We already did in this case more than we usually do for optional features, and I think it should be enough for now. Further efforts that increase our maintenance burden should wait until it is clear they are necessary.