Re: [Small change] Issue with dired-do-async-shell-command and certain shells

[Eli Zaretskii <eliz@gnu.org>]

> From: Lycomedes 1814 <lycomedes1814@yandex.com>
> Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
> Date: Fri, 19 May 2023 16:54:44 +0200
> 
> Sure, here's a diff:

Thanks.

> diff -u /home/jal/Code/emacs-patch/dired-aux.el /home/jal/Code/emacs-patch/dired-aux-new.el
> --- /home/jal/Code/emacs-patch/dired-aux.el    2023-05-19 14:45:53.360586128 +0000
> +++ /home/jal/Code/emacs-patch/dired-aux-new.el    2023-05-19 14:46:39.880476896 +0000
> @@ -945,7 +945,7 @@
>           ;; "&" instead.
>           (cmd-sep (if (and (or (not w32-shell) file-remote)
>                 (not parallel-in-background))
> -              ";" "&"))
> +              ";" "& "))

Here "&" is used only on MS-Windows, where I don't expect to see fish
as the shell.  Are you sure this is relevant to the problem?

> @@ -969,7 +969,7 @@
>                 ;; Add 'wait' to force those POSIX shells to wait until
>                 ;; all commands finish.
>                 (or (and parallel-in-background (not w32-shell)
> -                        "&wait")
> +                        "& wait")

This is the one we've been talking about from the beginning.

> @@ -977,7 +977,7 @@
>           (when (cdr file-list)
>             (setq files (concat dired-mark-prefix files dired-mark-postfix)))
>           (funcall stuff-it files))))
> -     (or (and in-background "&") ""))))
> +     (or (and in-background "& ") ""))))

This AFAIU is just appended to the end of the command, with nothing
after it.  Are you sure this one is needed?  If so, can you describe a
reproduction recipe where "&" here causes a problem and "& " doesn't?