From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: About commands to manage Python imports Date: Sun, 02 Jul 2023 07:49:20 +0300 Message-ID: <83fs66q5nz.fsf@gnu.org> References: <83pm5bpols.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12182"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Matthias Meulien Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jul 02 06:49:13 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qFp1N-000339-3P for ged-emacs-devel@m.gmane-mx.org; Sun, 02 Jul 2023 06:49:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qFp12-0006dd-2u; Sun, 02 Jul 2023 00:48:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFp0y-0006d1-6M for emacs-devel@gnu.org; Sun, 02 Jul 2023 00:48:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFp0x-0004YI-Tu; Sun, 02 Jul 2023 00:48:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=iPWZrGrpvwXqqXbs+Lc2Lux7AAK5GlSt5Mm2LlurpiQ=; b=etZhowoENwlG l4xUS5pFGjVEmXyd6tKQ88UuT1EyJDNRQCWJdGMQ5Oh3P708ClYAH8UMwPv9j3Sk4V4TEuLiz2tuS CzxCmxcG9SkjPkL8VR72oNx89WhmavnWTi1kOK7L5wqMxQjTqGt4kbMOClO3ikn6USnXXhFCk7PLp SFZGdkn6Umdy5SU1QjDDoJjPwhQxcPdnSegY4EkCvk/VbqO8omgtoneQff3pZJ0m1Gz+brNow8cyT dtA2d7pl3vhg+J/o4kjc6SOIAIM7BaAbFqvkhiXb4zTrVKMVQCGrwRUWbY26NHhnUJm1RQ312j1IN TqO3r2NewLpwyrnOpy+Znw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFp0x-0003iA-Bf; Sun, 02 Jul 2023 00:48:47 -0400 In-Reply-To: (message from Matthias Meulien on Sat, 1 Jul 2023 21:23:12 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:307342 Archived-At: > From: Matthias Meulien > Date: Sat, 1 Jul 2023 21:23:12 +0200 > Cc: emacs-devel > > > > If I read the logs correctly, commands python-add-import, > > python-fix-imports, etc. will be introduced > > > with Emacs 29. I am surprised there's no NEWS item related to those > > commands. Are the menu > > > entries considered enough? > > > > It's an omission. Feel free to write a NEWS entry and post it. > > > > Here is a proposal: > > diff --git a/etc/NEWS b/etc/NEWS > index 9e6f0c16bcd..f9621ef9164 100644 > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -3056,6 +3056,12 @@ Without a prefix argument, the kind of shell > (buffer-dedicated, > project-dedicated or global) is specified by the new > 'python-shell-dedicated' user option. > > +*** New commands to manage Python imports. > +'python-add-import', 'python-import-symbol-at-point', > +'python-remove-import', 'python-fix-imports', 'python-sort-imports'. > +The implementation relies on the Python library isort in version at > +least 5.7.0. > + > ** Ruby Mode Thanks. Two minor points: it should begin with "The new commands...", and it should say at least something about what these commands do. I'd also replace "in version" with "whose version". Thanks.