From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>, Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Re: Leak in selinux stuff?
Date: Sat, 19 Aug 2023 10:26:48 +0300 [thread overview]
Message-ID: <83fs4f1ohz.fsf@gnu.org> (raw)
In-Reply-To: <87y1i7em8t.fsf@yahoo.com> (message from Po Lu on Sat, 19 Aug 2023 11:37:06 +0800)
> From: Po Lu <luangruo@yahoo.com>
> Date: Sat, 19 Aug 2023 11:37:06 +0800
>
> fileio.c is littered with code like such:
>
> /* See https://debbugs.gnu.org/11245 for ENOTSUP. */
> if (fail && errno != ENOTSUP)
> report_file_error ("Doing lsetfilecon", absname);
>
> context_free (parsed_con);
> freecon (con);
>
> where `parsed_con' and `con' are allocated by libselinux functions by
> the likes of `lgetfilecon'. Around such code, no measures are
> apparently taken for deallocating those objects should a non local exit
> occur. Am I missing anything, or should this be fixed?
IMO, they should either free the resources before signaling an error,
or use record_unwind_protect to free the allocated resources, yes.
prev parent reply other threads:[~2023-08-19 7:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87y1i7em8t.fsf.ref@yahoo.com>
2023-08-19 3:37 ` Leak in selinux stuff? Po Lu
2023-08-19 7:26 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fs4f1ohz.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).