From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: ert-font-lock Date: Sat, 18 Nov 2023 14:43:09 +0200 Message-ID: <83fs13mduq.fsf@gnu.org> References: <87v89zz4v4.fsf@posteo.net> <87v89zjmcx.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24319"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, vekazanov@gmail.com, emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 18 13:43:39 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r4Kfi-000685-WD for ged-emacs-devel@m.gmane-mx.org; Sat, 18 Nov 2023 13:43:39 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r4KfN-000072-9d; Sat, 18 Nov 2023 07:43:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4KfM-00006c-E2 for emacs-devel@gnu.org; Sat, 18 Nov 2023 07:43:16 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4KfM-0008AB-1N; Sat, 18 Nov 2023 07:43:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=wo7dxmoeASJ6K3R12OCnX6htgqxs79EPPLMEjO88oLk=; b=R0s1CKSZf3Ke +f0CXnajCSjE4WY93c3efchJhVavridrwn7RcN4fBN8PuiO7MJpdbXVKExUstkNO2/akBkvz6u0h/ 9tv+fy/64SWMmBJsUIzd+bJCJz618ZfhzdIikDvu3QrrxMM93mgs/7Ig8RE5PfyaqnIMjsuQkZSZd 7ST9MnlT4iHb7o+he5H3fdCWRDOZv5GqyZJZ6Pc/8inA0Rlma7VuyexzmJy0qVB3JtwMMWMfqsfwz Xho9R4I60CThNdTkzY9rr6BgpWLeG9Y2Qv/BetsdSwyGqEvQD70Fc+MIpHy/7tIlLJCh6Rn6Bsyya DOqx9fQsz5JC/bIYZMxnPw==; In-Reply-To: <87v89zjmcx.fsf@yahoo.com> (message from Po Lu on Sat, 18 Nov 2023 20:07:42 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:312904 Archived-At: > From: Po Lu > Cc: Vladimir Kazanov , emacs-devel@gnu.org > Date: Sat, 18 Nov 2023 20:07:42 +0800 > > Philip Kaludercic writes: > > > ELPA shouls be fine. > > Since this is an adjunct to ERT, which is plausibly useful for the unit > testing of Emacs fontification code itself, I think such code should be > part of Emacs proper. I won't object to including this, FWIW. > BTW, this code requires cl-lib for a meager one macro. Please replace > > (cl-incf curline) > > with > > (setq curline (1+ curline)) > > that cl-lib might not be loaded either at compile-time or runtime. > There is no rationale for requiring cl-lib so as to employ a single > macro once. Doesn't this library require ert? if it does, cl-lib is already loaded by ert. But if people like cl-incf so much, we could just add incf to subr.el or something.