From: Eli Zaretskii <eliz@gnu.org>
To: Alan Mackenzie <acm@muc.de>
Cc: monnier@iro.umontreal.ca, eggert@cs.ucla.edu, emacs-devel@gnu.org
Subject: Re: Excessive use of `eassert`
Date: Fri, 19 Jan 2024 21:56:10 +0200 [thread overview]
Message-ID: <83frytumg5.fsf@gnu.org> (raw)
In-Reply-To: <ZarQr591SsuIZwNs@ACM> (message from Alan Mackenzie on Fri, 19 Jan 2024 19:42:39 +0000)
> Date: Fri, 19 Jan 2024 19:42:39 +0000
> Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
> Paul Eggert <eggert@cs.ucla.edu>, emacs-devel@gnu.org
> From: Alan Mackenzie <acm@muc.de>
>
> > > Why do you find this specific assertion important? When building other
> > > `Lisp_Object`s (like `make_fixnum`) we don't seem to have any
> > > corresponding assertion that the revere operation (e.g. XFIXNUM) returns
> > > the original value.
>
> > make_fixnum is a trivial bit-shuffling, whereas make_lisp_symbol is
> > much trickier. Perhaps especially so now that we have
> > symbols-with-positions as well as bare symbols.
>
> Not really. Symbols with positions don't belong in the obarray. If they
> somehow get there, then that's a bug to be fixed.
Does that mean you'd like the assertion to be left there, or does that
mean you don't care if it were removed?
next prev parent reply other threads:[~2024-01-19 19:56 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 22:35 Excessive use of `eassert` Stefan Monnier
2024-01-19 7:04 ` Eli Zaretskii
2024-01-19 13:01 ` Stefan Monnier
2024-01-19 15:02 ` Eli Zaretskii
2024-01-19 15:50 ` Stefan Monnier
2024-01-19 16:23 ` Eli Zaretskii
2024-01-19 17:44 ` Stefan Monnier
2024-01-19 19:42 ` Alan Mackenzie
2024-01-19 19:56 ` Eli Zaretskii [this message]
2024-01-21 1:41 ` Paul Eggert
2024-01-21 9:57 ` Eli Zaretskii
2024-01-21 20:35 ` Paul Eggert
2024-01-21 10:59 ` Alan Mackenzie
2024-01-22 5:19 ` Paul Eggert
2024-01-22 13:07 ` Stefan Monnier
2024-01-22 14:37 ` Alan Mackenzie
2024-01-23 7:51 ` Paul Eggert
2024-01-23 11:42 ` Alan Mackenzie
2024-01-24 1:04 ` Paul Eggert
2024-01-24 15:09 ` Alan Mackenzie
2024-01-26 8:06 ` Paul Eggert
2024-01-21 15:54 ` Stefan Monnier
2024-01-22 4:12 ` Paul Eggert
2024-01-22 13:20 ` Stefan Monnier
2024-01-23 8:15 ` Paul Eggert
2024-01-23 17:11 ` Stefan Monnier
2024-01-24 7:45 ` Paul Eggert
2024-01-23 18:16 ` Eli Zaretskii
2024-01-23 19:50 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83frytumg5.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=acm@muc.de \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).