From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: HAVE_SOCKETS in w32*
Date: Wed, 15 Sep 2010 21:34:39 +0200
Message-ID: <83eicu3ink.fsf@gnu.org>
References: <yxqvd7p5418.fsf@fencepost.gnu.org>
	<AANLkTimmdVMd2EZW3aJ7XZX1XWZw6mhmJdDh6ALxg-Mu@mail.gmail.com>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: lo.gmane.org
X-Trace: dough.gmane.org 1284579319 15180 80.91.229.12 (15 Sep 2010 19:35:19 GMT)
X-Complaints-To: usenet@dough.gmane.org
NNTP-Posting-Date: Wed, 15 Sep 2010 19:35:19 +0000 (UTC)
Cc: dann@gnu.org, emacs-devel@gnu.org
To: Juanma Barranquero <lekktu@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 15 21:35:16 2010
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by lo.gmane.org with esmtp (Exim 4.69)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1OvxlD-0006oS-VE
	for ged-emacs-devel@m.gmane.org; Wed, 15 Sep 2010 21:35:16 +0200
Original-Received: from localhost ([127.0.0.1]:35180 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1OvxlD-0007Os-AB
	for ged-emacs-devel@m.gmane.org; Wed, 15 Sep 2010 15:35:15 -0400
Original-Received: from [140.186.70.92] (port=46026 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ovxl4-0007OZ-FH
	for emacs-devel@gnu.org; Wed, 15 Sep 2010 15:35:11 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <eliz@gnu.org>) id 1Ovxl3-00069s-B8
	for emacs-devel@gnu.org; Wed, 15 Sep 2010 15:35:06 -0400
Original-Received: from mtaout20.012.net.il ([80.179.55.166]:55824)
	by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from <eliz@gnu.org>)
	id 1Ovxl1-00069T-Pl; Wed, 15 Sep 2010 15:35:03 -0400
Original-Received: from conversion-daemon.a-mtaout20.012.net.il by
	a-mtaout20.012.net.il (HyperSendmail v2007.08) id
	<0L8S00K00ZMDYT00@a-mtaout20.012.net.il>;
	Wed, 15 Sep 2010 21:34:39 +0200 (IST)
Original-Received: from HOME-C4E4A596F7 ([77.127.81.53]) by a-mtaout20.012.net.il
	(HyperSendmail v2007.08) with ESMTPA id
	<0L8S00I11ZPOUQO0@a-mtaout20.012.net.il>;
	Wed, 15 Sep 2010 21:34:37 +0200 (IST)
In-reply-to: <AANLkTimmdVMd2EZW3aJ7XZX1XWZw6mhmJdDh6ALxg-Mu@mail.gmail.com>
X-012-Sender: halo1@inter.net.il
X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:130232
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/130232>

> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Wed, 15 Sep 2010 03:46:11 +0200
> Cc: emacs-devel@gnu.org
> 
> On Thu, Aug 5, 2010 at 20:05, Dan Nicolaescu <dann@gnu.org> wrote:
> 
> > HAVE_SOCKETS is defined unconditionally in s/ms-w32.h, yet some w32*.c
> > files use HAVE_SOCKETS #ifdefs.
> >
> > It would be good to get rid of those.
> 
> The following patch does that; it also removes the few uses of
> SOCK_REPLACE_HANDLE, which has been commented out since 1996.
> 
> Eli, Jason?

Looks good to me.  Thanks.