From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Buffer size limitation in insdel.c Date: Thu, 23 Sep 2010 16:41:23 +0200 Message-ID: <83eickv7xo.fsf@gnu.org> References: <834odivv7v.fsf@gnu.org> <83r5gkvqpf.fsf@gnu.org> <83iq1wvep4.fsf@gnu.org> <83hbhgvblq.fsf@gnu.org> <83fwx0v97g.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1285252900 19575 80.91.229.12 (23 Sep 2010 14:41:40 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 23 Sep 2010 14:41:40 +0000 (UTC) Cc: emacs-devel@gnu.org To: Lars Magne Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 23 16:41:38 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OymzO-0004jD-EZ for ged-emacs-devel@m.gmane.org; Thu, 23 Sep 2010 16:41:34 +0200 Original-Received: from localhost ([127.0.0.1]:44965 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OymzN-0005MZ-QE for ged-emacs-devel@m.gmane.org; Thu, 23 Sep 2010 10:41:33 -0400 Original-Received: from [140.186.70.92] (port=53835 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OymzF-0005M4-OQ for emacs-devel@gnu.org; Thu, 23 Sep 2010 10:41:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OymzB-0005dB-FO for emacs-devel@gnu.org; Thu, 23 Sep 2010 10:41:25 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:58657) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OymzB-0005cu-80 for emacs-devel@gnu.org; Thu, 23 Sep 2010 10:41:21 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0L9700N00FAP2R00@a-mtaout23.012.net.il> for emacs-devel@gnu.org; Thu, 23 Sep 2010 16:41:19 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.127.203.3]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L9700N1TFGU3500@a-mtaout23.012.net.il>; Thu, 23 Sep 2010 16:41:19 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:130669 Archived-At: > From: Lars Magne Ingebrigtsen > Date: Thu, 23 Sep 2010 16:21:58 +0200 > > matrix->window_left_col = (((((long) ((w)->left_col)) >> (3 - 1)))); > > So the warning is incorrect -- it's no longer a Lisp_Object at that > point. But it's correct in that it's a potentially problematic > conversion. (But probably isn't in actuality, since it's unlikely > w->left_col really is a more than 31 bits.) An explicit cast to int should shut it up (but you never know, with GCC 4.x...).