unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Dan Nicolaescu <dann@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: <sys/ioctl.h> on msdos
Date: Sat, 20 Nov 2010 11:08:35 +0200	[thread overview]
Message-ID: <83eiagbbvw.fsf@gnu.org> (raw)
In-Reply-To: <yxqeiagbfzt.fsf@fencepost.gnu.org>

> Cc: emacs-devel@gnu.org
> From: Dan Nicolaescu <dann@gnu.org>
> Date: Sat, 20 Nov 2010 02:39:50 -0500
> 
> Are you sure that including sys/ioctl.h unconditionally has some bad effects?

No, I'm not.  It's just good engineering practice.

> Is HAVE_SYS_IOCTL_H currently defined?

Yes.  It's defined by one of the system headers included by config.h
(after config.in is edited by msdos/sed2v2.inp).

> If yes, then it seems that the only extra places to include sys/ioctl.h would be
> keyboard.c and sound.c.

sound.c doesn't matter, since MSDOS does not define HAVE_SOUND (so we
can remove that part altogether from sound.c).

Are you planning on removing HAVE_SYS_IOCTL_H altogether and not
testing for it in `configure'?  Because if HAVE_SYS_IOCTL_H is to
stay, there could be no harm in undefining HAVE_SYS_IOCTL_H on MSDOS:
it will be in on of the msdos/ Sed scripts, not visible in any of the
Emacs sources.  We will just replace a couple of "#ifndef MSDOS" with
"#ifdef HAVE_SYS_IOCTL_H".

If you do want to remove HAVE_SYS_IOCTL_H, then I guess it would be
okay to remove the MSDOS conditions from the places that include
sys/ioctl.h, and see if anything breaks.



  reply	other threads:[~2010-11-20  9:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-18  4:42 <sys/ioctl.h> on msdos Dan Nicolaescu
2010-11-18 10:26 ` Eli Zaretskii
2010-11-19 17:54   ` Eli Zaretskii
2010-11-20  7:39     ` Dan Nicolaescu
2010-11-20  9:08       ` Eli Zaretskii [this message]
2010-11-21  4:40         ` Dan Nicolaescu
2010-11-21 17:45           ` Eli Zaretskii
2010-11-26 12:17           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83eiagbbvw.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=dann@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).