From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 4/4] Fix emacsclient to work with cygw32 Date: Thu, 29 Dec 2011 20:18:59 +0200 Message-ID: <83ehvnutpo.fsf@gnu.org> References: <3a4c4669da1d97d72975e8943d7b8edff22427c1.1325166472.git.dancol@dancol.org> <83mxabuvj2.fsf@gnu.org> <4EFCA9DB.3030002@dancol.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1325182755 11921 80.91.229.12 (29 Dec 2011 18:19:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 29 Dec 2011 18:19:15 +0000 (UTC) Cc: emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 29 19:19:07 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RgKZF-0003LM-O0 for ged-emacs-devel@m.gmane.org; Thu, 29 Dec 2011 19:19:05 +0100 Original-Received: from localhost ([::1]:46643 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgKZE-0002VV-RG for ged-emacs-devel@m.gmane.org; Thu, 29 Dec 2011 13:19:04 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:48178) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgKZC-0002VF-20 for emacs-devel@gnu.org; Thu, 29 Dec 2011 13:19:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RgKZB-0006Ni-3U for emacs-devel@gnu.org; Thu, 29 Dec 2011 13:19:02 -0500 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:50220) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgKZA-0006Ne-SN for emacs-devel@gnu.org; Thu, 29 Dec 2011 13:19:01 -0500 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0LWZ00D009AA6100@a-mtaout21.012.net.il> for emacs-devel@gnu.org; Thu, 29 Dec 2011 20:18:59 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.126.18.76]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LWZ00DK49JM5W10@a-mtaout21.012.net.il>; Thu, 29 Dec 2011 20:18:59 +0200 (IST) In-reply-to: <4EFCA9DB.3030002@dancol.org> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:147010 Archived-At: > Date: Thu, 29 Dec 2011 09:56:43 -0800 > From: Daniel Colascione > CC: emacs-devel@gnu.org > > > [1:text/plain Hide] > > On 12/29/11 9:39 AM, Eli Zaretskii wrote: > >> Date: Thu, 29 Dec 2011 06:03:20 -0800 > >> From: Daniel Colascione > >> > >> @@ -184,7 +188,7 @@ struct option longopts[] = > >> { "socket-name", required_argument, NULL, 's' }, > >> #endif > >> { "server-file", required_argument, NULL, 'f' }, > >> -#ifndef WINDOWSNT > >> +#ifndef HAVE_NTGUI > >> { "display", required_argument, NULL, 'd' }, > >> #endif > > > > Maybe I'm confused: will HAVE_NTGUI be applicable to the Cygwin build > > that can use the w32 windowing? If so, it sounds like you are > > creating here 2 kinds of emacsclient: one that can talk to a Cygwin > > Emacs with X frames on another display, the other that cannot. Why > > cannot the same emacsclient work with both types of Emacs frames in a > > Cygwin Emacs? > > > > Apologies if I've misread the changes. > > No, you're right. I was following the template of the existing code > here; IIUC, removing the conditional in the hunk above will let the same > emacsclient talk to any kind of Emacs. But the ifdef-out must stay in the native w32 build, I think, because it causes trouble further down the line. Juanma, can you comment, please?