From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r113822: Add a test for decompressing gzipped data Date: Tue, 13 Aug 2013 19:02:31 +0300 Message-ID: <83eh9xpoiw.fsf@gnu.org> References: <83iozapan0.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1376409785 16056 80.91.229.3 (13 Aug 2013 16:03:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 13 Aug 2013 16:03:05 +0000 (UTC) Cc: lekktu@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Lars Magne Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 13 18:03:05 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1V9H3n-0002ID-Ju for ged-emacs-devel@m.gmane.org; Tue, 13 Aug 2013 18:03:03 +0200 Original-Received: from localhost ([::1]:37833 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V9H3m-0000rB-IQ for ged-emacs-devel@m.gmane.org; Tue, 13 Aug 2013 12:03:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45608) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V9H3I-0000A2-8b for emacs-devel@gnu.org; Tue, 13 Aug 2013 12:02:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V9H3D-00071y-Ej for emacs-devel@gnu.org; Tue, 13 Aug 2013 12:02:32 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:61993) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V9H3D-00071f-7e for emacs-devel@gnu.org; Tue, 13 Aug 2013 12:02:27 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MRH00F008FXA100@a-mtaout23.012.net.il> for emacs-devel@gnu.org; Tue, 13 Aug 2013 19:02:05 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MRH00FDY8JG2FD0@a-mtaout23.012.net.il>; Tue, 13 Aug 2013 19:02:05 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.175 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:162664 Archived-At: > From: Lars Magne Ingebrigtsen > Cc: Eli Zaretskii , Stefan Monnier , Emacs developers > Date: Tue, 13 Aug 2013 11:54:58 +0200 > > I think that `zlib-available-p' should probably always be defined. > And return the correct answer, that is. > > So it should be move out of the #ifdef HAVE_ZLIB region, although that > requires a bit more rejuggling; what with calling syms_of_decompress > always etc. Exactly. And, since neither gnutls.c nor xml.c do anything like that, I've decided not to. If we want the available-p predicates be always, err..., available, then IMO we should do that in those two files as well.