From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix browse-url not working when browse-url-browser-function is a list (regexp . function) pairs Date: Sat, 25 Apr 2015 19:28:47 +0300 Message-ID: <83egn8xjcw.fsf@gnu.org> References: <878udhwgwo.fsf@gmail.com> <87h9s418yi.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1429979364 1893 80.91.229.3 (25 Apr 2015 16:29:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 25 Apr 2015 16:29:24 +0000 (UTC) Cc: emacs-devel@gnu.org To: vibhavp@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 25 18:29:11 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ym2x4-0008Mc-6e for ged-emacs-devel@m.gmane.org; Sat, 25 Apr 2015 18:29:10 +0200 Original-Received: from localhost ([::1]:48888 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ym2x3-00052j-Bg for ged-emacs-devel@m.gmane.org; Sat, 25 Apr 2015 12:29:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45167) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ym2x0-00052e-Pk for emacs-devel@gnu.org; Sat, 25 Apr 2015 12:29:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ym2wx-00074j-LG for emacs-devel@gnu.org; Sat, 25 Apr 2015 12:29:06 -0400 Original-Received: from mtaout26.012.net.il ([80.179.55.182]:38677) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ym2wx-00074d-Dl for emacs-devel@gnu.org; Sat, 25 Apr 2015 12:29:03 -0400 Original-Received: from conversion-daemon.mtaout26.012.net.il by mtaout26.012.net.il (HyperSendmail v2007.08) id <0NND00C00F6B9V00@mtaout26.012.net.il> for emacs-devel@gnu.org; Sat, 25 Apr 2015 19:30:38 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout26.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NND005WJF716U50@mtaout26.012.net.il>; Sat, 25 Apr 2015 19:30:38 +0300 (IDT) In-reply-to: <87h9s418yi.fsf@gmail.com> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:185876 Archived-At: > From: vibhavp@gmail.com > Date: Sat, 25 Apr 2015 21:44:29 +0530 > > Are there any objections to the patch? But the way browse-url-browser-function is documented, it should be a list of conses, not a list of lists. With your change, if browse-url-browser-function is an alist, like the doc string implies, the function will now fail. So other users out there might suffer. I'd be okay with a backward compatible change that would work with both forms, but such a change will have to be accompanied by a suitable change in documentation. Thanks.