From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-25 3722a69: Fix bugs in window resizing code Date: Tue, 01 Mar 2016 19:20:04 +0200 Message-ID: <83egbu6rp7.fsf@gnu.org> References: <20160218102715.15576.42604@vcs.savannah.gnu.org> <87si0bj85l.fsf@wanadoo.es> <56D54DB4.1080502@gmx.at> <878u22jksw.fsf@wanadoo.es> <56D5CB91.4060108@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1456852838 1715 80.91.229.3 (1 Mar 2016 17:20:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 1 Mar 2016 17:20:38 +0000 (UTC) Cc: ofv@wanadoo.es, emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 01 18:20:33 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aanyL-0007ay-OG for ged-emacs-devel@m.gmane.org; Tue, 01 Mar 2016 18:20:33 +0100 Original-Received: from localhost ([::1]:51307 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aanyL-0000qP-02 for ged-emacs-devel@m.gmane.org; Tue, 01 Mar 2016 12:20:33 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aany7-0000q6-QD for emacs-devel@gnu.org; Tue, 01 Mar 2016 12:20:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aany3-0000QZ-7G for emacs-devel@gnu.org; Tue, 01 Mar 2016 12:20:19 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36623) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aany3-0000QS-3x; Tue, 01 Mar 2016 12:20:15 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2279 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aany2-00052V-Cz; Tue, 01 Mar 2016 12:20:14 -0500 In-reply-to: <56D5CB91.4060108@gmx.at> (message from martin rudalics on Tue, 01 Mar 2016 18:04:17 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:200855 Archived-At: > Date: Tue, 01 Mar 2016 18:04:17 +0100 > From: martin rudalics > Cc: emacs-devel@gnu.org > > > `enlarge-window' appears on several places on the Elisp sources, > > including calls like > > > > textmodes/two-column.el:305:6: (enlarge-window 99999 t)) > > > > which now will result on a error. > > Ugly. Earlier, with code like this you never knew whether the author's > intention was to maximize the window or to delete all other windows in > the same combination. The author should either use ‘maximize-window’ or > `delete-other-windows-vertically' instead. Please file a bug report. > > > To be clear, I have nothing against throwing an error on the interactive > > case, but against throwing the error on the non-interactive one. That's > > what constitutes an API change on my book. > > > > So I would suggest to remove the `error' and consider where and when to > > add it after the release, after studying the code in the wild. > > I can make any change people want but won't make any decision. John, > Eli? MO is that we should fix all uses of enlarge-window and shrink-window in our sources, and otherwise leave the change in 25.1. Maybe also document that in NEWS as potentially incompatible behavior. I don't think we should postpone the bugfix to 26.1, because I don't really believe anything will happen until then that will change the situation: the same problems this could cause now it will cause then.