From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Native display of line numbers Date: Sat, 17 Jun 2017 21:25:52 +0300 Message-ID: <83efuizd1r.fsf@gnu.org> References: <83lgoqzm0v.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1497724015 13063 195.159.176.226 (17 Jun 2017 18:26:55 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 17 Jun 2017 18:26:55 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 17 20:26:47 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMIQn-0002rs-T2 for ged-emacs-devel@m.gmane.org; Sat, 17 Jun 2017 20:26:45 +0200 Original-Received: from localhost ([::1]:35939 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMIQt-0004Vr-7o for ged-emacs-devel@m.gmane.org; Sat, 17 Jun 2017 14:26:51 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41360) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMIQG-0004Vl-78 for emacs-devel@gnu.org; Sat, 17 Jun 2017 14:26:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dMIQD-0005YL-4V for emacs-devel@gnu.org; Sat, 17 Jun 2017 14:26:12 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44691) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMIQD-0005YD-1D; Sat, 17 Jun 2017 14:26:09 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2628 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dMIQC-0001ah-4J; Sat, 17 Jun 2017 14:26:08 -0400 In-reply-to: (message from Stefan Monnier on Sat, 17 Jun 2017 12:41:50 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:215710 Archived-At: > From: Stefan Monnier > Date: Sat, 17 Jun 2017 12:41:50 -0400 > > > So with that in mind, I came up with an implementation of a native > > display of line numbers. > > Cool! Thanks. > > . it works significantly faster (almost twice as fast as linum-mode, > > 50% faster that relative-line-numbers-mode) > > Should I read this to me that the speed difference w.r.t nlinum is not > that large, or you didn't bother comparing? See my other message: I did compare with it, of course, but the performance was very poor. Maybe it wasn't supposed to provide a great performance in a file like xdisp.c. Or maybe my benchmark is skewed (in which case I'm sure you will provide a better one). > > . it works with R2L text, something the old modes never did > > I didn't know there were problems with R2L text. Worse: even now that > you tell me, I can't think of nor find a problem with it (other than the > choice of whether to display the line numbers in the left or right > margin). The fact that the numbers are always displayed on the left is bad enough; worse, the digits in the numbers are in reverse order. E.g., visit TUTORIAL.he, then turn on linum-mode or nlinum-mode, and watch the numbers closely.