From: Eli Zaretskii <eliz@gnu.org>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: phst@google.com, emacs-devel@gnu.org
Subject: Re: [PATCH] Improve error reporting when serializing non-Unicode strings to JSON
Date: Sat, 23 Dec 2017 10:28:29 +0200 [thread overview]
Message-ID: <83efnllufm.fsf@gnu.org> (raw)
In-Reply-To: <20171222210031.30811-1-phst@google.com> (message from Philipp Stephani on Fri, 22 Dec 2017 22:00:31 +0100)
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Fri, 22 Dec 2017 22:00:31 +0100
> Cc: Philipp Stephani <phst@google.com>
>
> * admin/merge-gnulib (GNULIB_MODULES): Add unistr modules.
>
> * lib/Makefile.in (.c.o): Fix output file for files in subdirectories.
> (${DEPDIR}/unistr, unistr/u8-check.o): Create missing deps directory.
>
> * src/json.c (json_check_utf8): New helper function.
> (lisp_to_json_toplevel_1, lisp_to_json): Use it. To save a bit of
> time, check for invalid UTF-8 strings only after encountering an
> error, since Jansson already rejects them.
>
> * test/src/json-tests.el (json-serialize/invalid-unicode): Adapt
> expected error symbol.
I'm not sure I understand the need for this. Emacs never does that
anywhere else, it just converts the invalid bytes to a special
character set. An application that cares could then test for presence
of those bytes to see if anything like that happened. What am I
missing?
next prev parent reply other threads:[~2017-12-23 8:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 21:00 [PATCH] Improve error reporting when serializing non-Unicode strings to JSON Philipp Stephani
2017-12-23 8:28 ` Eli Zaretskii [this message]
2017-12-23 12:33 ` Philipp Stephani
2017-12-23 13:44 ` Eli Zaretskii
2017-12-23 14:29 ` Philipp Stephani
2017-12-23 14:52 ` Eli Zaretskii
2017-12-23 15:00 ` Eli Zaretskii
2017-12-23 15:07 ` Philipp Stephani
2017-12-23 15:19 ` Philipp Stephani
2017-12-23 15:34 ` Eli Zaretskii
2017-12-23 16:20 ` Philipp Stephani
2017-12-23 16:36 ` Eli Zaretskii
2017-12-23 16:58 ` Philipp Stephani
2017-12-23 16:58 ` Philipp Stephani
2017-12-30 22:20 ` Philipp Stephani
2017-12-31 15:52 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83efnllufm.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=p.stephani2@gmail.com \
--cc=phst@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).