From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-26 b90e91c: Fix last change of @key markup Date: Thu, 01 Feb 2018 21:39:45 +0200 Message-ID: <83efm4eby6.fsf@gnu.org> References: <20180201175714.3571.11628@vcs0.savannah.gnu.org> <20180201175715.624202068E@vcs0.savannah.gnu.org> <877erwpmvb.fsf@gmx.de> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1517514655 18219 195.159.176.226 (1 Feb 2018 19:50:55 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 1 Feb 2018 19:50:55 +0000 (UTC) Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 01 20:50:51 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehKs9-0002AW-AD for ged-emacs-devel@m.gmane.org; Thu, 01 Feb 2018 20:50:13 +0100 Original-Received: from localhost ([::1]:58045 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ehKu8-000324-Rm for ged-emacs-devel@m.gmane.org; Thu, 01 Feb 2018 14:52:16 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:51266) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ehKnl-0007p7-9c for emacs-devel@gnu.org; Thu, 01 Feb 2018 14:49:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ehKhl-0004sI-Ex for emacs-devel@gnu.org; Thu, 01 Feb 2018 14:40:35 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52663) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ehKhl-0004s0-8c; Thu, 01 Feb 2018 14:39:29 -0500 Original-Received: from [176.228.60.248] (port=2146 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ehKhk-0007X9-Lq; Thu, 01 Feb 2018 14:39:29 -0500 In-reply-to: <877erwpmvb.fsf@gmx.de> (message from Michael Albinus on Thu, 01 Feb 2018 19:48:24 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222368 Archived-At: > From: Michael Albinus > Cc: Eli Zaretskii > Date: Thu, 01 Feb 2018 19:48:24 +0100 > > for future changes I might apply, could you pls tell me what was wrong > with my changes? @key is only for names of keys, not for names of characters or commands. Your changes to add @key were mostly good, but they went a notch too far, in that they included _any_ instance of "TAB" or "RET" or "SPC", including, for example, this: @item big-indent @vindex whitespace-big-indent-regexp Highlight too-deep indentation. By default any sequence of at least 4 consecutive TAB characters or 32 consecutive SPC characters is highlighted. To change that, customize the regular expression Here, TAB and SPC refer to characters, not keys. If that still doesn't make the criterion clear, consider this: the purpose of @key is to avoid the erroneous interpretation of "RET" to mean literal 3 characters R E T. And such an erroneous interpretation can only happen in the context of describing keyboard input or keys the user presses, it cannot happen when the text refers to characters, as in the above excerpt. (Another way of looking at this is to see how TeX renders @key: the result looks like a key on a keyboard, and that is, of course, inappropriate when talking about anything other than a keyboard key.) HTH