From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Questionable code in handling of wordend in the regexp engine in regex-emacs.c Date: Sat, 02 Mar 2019 14:21:49 +0200 Message-ID: <83ef7ph3fm.fsf@gnu.org> References: <20190301111018.GA5674@ACM> <83bm2uiu6x.fsf@gnu.org> <20190301141448.GC5674@ACM> <834l8mirj9.fsf@gnu.org> <20190301145856.GE5674@ACM> <83zhqeh8ds.fsf@gnu.org> <20190301163824.GF5674@ACM> <20190301191607.GG5674@ACM> <83woligzmu.fsf@gnu.org> <20190302111640.GA21061@ACM> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="186853"; mail-complaints-to="usenet@blaine.gmane.org" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 02 13:23:22 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h03fm-000mTw-D3 for ged-emacs-devel@m.gmane.org; Sat, 02 Mar 2019 13:23:22 +0100 Original-Received: from localhost ([127.0.0.1]:53313 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h03fl-00075d-Bc for ged-emacs-devel@m.gmane.org; Sat, 02 Mar 2019 07:23:21 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52673) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h03eR-00075F-Ih for emacs-devel@gnu.org; Sat, 02 Mar 2019 07:22:00 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39905) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h03eR-0003DH-2t; Sat, 02 Mar 2019 07:21:59 -0500 Original-Received: from [176.228.60.248] (port=4017 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h03eQ-0003Sn-Mp; Sat, 02 Mar 2019 07:21:59 -0500 In-reply-to: <20190302111640.GA21061@ACM> (message from Alan Mackenzie on Sat, 2 Mar 2019 11:16:40 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233764 Archived-At: > Date: Sat, 2 Mar 2019 11:16:40 +0000 > From: Alan Mackenzie > Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org Forgot to answer this part: > In fact, is buf_bytepos_to_charpos the Right Thing to use here? Yes, because decode-coding-region must also work in a multibyte buffer. The code in buf_bytepos_to_charpos takes care of the unibyte use case right away, returning a trivial 1:1 mapping: /* If this buffer has as many characters as bytes, each character must be one byte. This takes care of the case where enable-multibyte-characters is nil. */ if (best_above == best_above_byte) return bytepos;