From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Renaming non-X x_* procedures in xdisp.c (and elsewhere) Date: Sat, 23 Mar 2019 18:10:04 +0200 Message-ID: <83ef6xpo6b.fsf@gnu.org> References: <87wokp4okn.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="205715"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Alex Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 23 17:10:14 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h7jDq-000rQA-Bm for ged-emacs-devel@m.gmane.org; Sat, 23 Mar 2019 17:10:14 +0100 Original-Received: from localhost ([127.0.0.1]:45267 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7jDp-0007AQ-7M for ged-emacs-devel@m.gmane.org; Sat, 23 Mar 2019 12:10:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51832) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7jDi-00079d-TI for emacs-devel@gnu.org; Sat, 23 Mar 2019 12:10:07 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35647) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7jDi-0002xV-Nn; Sat, 23 Mar 2019 12:10:06 -0400 Original-Received: from [176.228.60.248] (port=2577 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h7jDg-0007v2-K1; Sat, 23 Mar 2019 12:10:06 -0400 In-reply-to: <87wokp4okn.fsf@gmail.com> (message from Alex on Sat, 23 Mar 2019 09:07:04 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234650 Archived-At: > From: Alex > Date: Sat, 23 Mar 2019 09:07:04 -0600 > > It would be helpful to determine at a glance whether or not a procedure > is generic or depends on X support. As a rule of thumb that is 99% true, everything in xdisp.c is generic, i.e. independent of the terminal-specific implementation. The terminal-dependent stuff is in xterm.c/xfns.c (for X), w32term.c/w32fns.c (for w32), nsterm.m/nsfns.m (for NS), and term.c (for TTY). > I'm guessing that this naming scheme is a historical artifact from > when graphical support meant X support, but I believe that it is > more confusing than it is worth at this point. > > For example, x_write_glyphs could become disp_write_glyphs. The correct name would be something like gui_write_glyphs, since there's tty_write_glyphs in term.c. Although I personally fail to see how such renaming will help anyone or anything.