From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: master ed2b0bd: New faces in xref (bug#23179)
Date: Tue, 16 Apr 2019 18:07:40 +0300
Message-ID: <83ef62gf9f.fsf@gnu.org>
References: <20190413215421.15465.98417@vcs0.savannah.gnu.org>
	<20190413215422.72DC12044D@vcs0.savannah.gnu.org>
	<m2ftqkdg6m.fsf@gmail.com> <87o958wdwt.fsf@mail.linkov.net>
	<m21s2365by.fsf@gmail.com> <83lg0bibh6.fsf@gnu.org>
	<m2sguif3pf.fsf@gmail.com>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="54037"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: Robert Pluim <rpluim@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 16 17:08:37 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hGPhN-000DwI-Ck
	for ged-emacs-devel@m.gmane.org; Tue, 16 Apr 2019 17:08:37 +0200
Original-Received: from localhost ([127.0.0.1]:38168 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hGPhM-0001Qs-6Q
	for ged-emacs-devel@m.gmane.org; Tue, 16 Apr 2019 11:08:36 -0400
Original-Received: from eggs.gnu.org ([209.51.188.92]:35100)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1hGPgk-0001QW-FO
	for emacs-devel@gnu.org; Tue, 16 Apr 2019 11:07:59 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50400)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1hGPgY-0003rO-Q3; Tue, 16 Apr 2019 11:07:49 -0400
Original-Received: from [176.228.60.248] (port=2543 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1hGPgX-00057E-V2; Tue, 16 Apr 2019 11:07:46 -0400
In-reply-to: <m2sguif3pf.fsf@gmail.com> (message from Robert Pluim on Tue, 16
	Apr 2019 16:02:36 +0200)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:235521
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/235521>

> From: Robert Pluim <rpluim@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Tue, 16 Apr 2019 16:02:36 +0200
> 
> +@cindex compilation mode faces
> +@cindex compilation mode appearance
> +@vindex compilation-error-face
> +@vindex compilation-error
> +@vindex compilation-warning-face
> +@vindex compilation-warning

It is generally not useful to have several index entries which start
with the same text and point to the same place.  So I would leave the
odd-numbered entries above and delete the even-numbered.

> +  The appearance of the @file{*compilation*} buffer can be controlled
> +by customizing the faces which are used to highlight parts of the
> +@file{*compilation*} buffer, e.g. @code{compilation-error} or

Either "e.g.,", or "e.g.@:", so that TeX doesn't by chance consider
this end of sentence.

Otherwise LGTM, thanks.