From: Eli Zaretskii <eliz@gnu.org>
To: Alex Gramiak <agrambot@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Remove display member of glyph_string
Date: Thu, 09 May 2019 08:50:13 +0300 [thread overview]
Message-ID: <83ef58goru.fsf@gnu.org> (raw)
In-Reply-To: <87a7fwe12f.fsf@gmail.com> (message from Alex Gramiak on Wed, 08 May 2019 21:52:56 -0600)
> From: Alex Gramiak <agrambot@gmail.com>
> Date: Wed, 08 May 2019 21:52:56 -0600
Each FRAME_X_DISPLAY call expands into applying a struct offset 4
times. Do we care about the (small) additional inefficiency? AFAIU,
that was the cause for maintaining the result inside the glyph_string
structure in the first place.
> The only other location that FRAME_X_DISPLAY appears in non-X code is in
> the argument to Free_Pixmap in image.c, which can hopefully be
> refactored out in a later patch; at that point the other terms can
> remove their trivial FRAME_X_DISPLAY definitions.
So should we do both in one go, perhaps?
Thanks.
next prev parent reply other threads:[~2019-05-09 5:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 3:52 [PATCH] Remove display member of glyph_string Alex Gramiak
2019-05-09 5:50 ` Eli Zaretskii [this message]
2019-05-09 16:07 ` Alex Gramiak
2019-05-09 17:02 ` Eli Zaretskii
2019-05-09 17:16 ` Alex Gramiak
2019-05-09 17:59 ` Eli Zaretskii
2019-05-09 18:21 ` Alex Gramiak
2019-05-10 5:30 ` Eli Zaretskii
2019-05-11 4:20 ` Alex Gramiak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ef58goru.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=agrambot@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).