From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Tabs Date: Sun, 01 Sep 2019 17:40:51 +0300 Message-ID: <83ef1084gc.fsf@gnu.org> References: <87a7bpysm8.fsf@mail.linkov.net> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="48899"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org, juri@linkov.net To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 01 16:41:51 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i4R38-000CbF-AE for ged-emacs-devel@m.gmane.org; Sun, 01 Sep 2019 16:41:50 +0200 Original-Received: from localhost ([::1]:57850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i4R37-0001N0-2w for ged-emacs-devel@m.gmane.org; Sun, 01 Sep 2019 10:41:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41799) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i4R2O-0001Mh-W7 for emacs-devel@gnu.org; Sun, 01 Sep 2019 10:41:05 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48455) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i4R2O-0005F7-Ds; Sun, 01 Sep 2019 10:41:04 -0400 Original-Received: from [176.228.60.248] (port=4297 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i4R2N-0001hO-DB; Sun, 01 Sep 2019 10:41:03 -0400 In-reply-to: (message from martin rudalics on Sun, 1 Sep 2019 10:12:41 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239754 Archived-At: > From: martin rudalics > Date: Sun, 1 Sep 2019 10:12:41 +0200 > > > now a complete implementation is available for these > > etc/TODO tasks: > > To make your branch build on Windows you need to install the attached > patch at least (blindly copied from its X counterparts). Therafter, > Emacs builds and comes up normally. Thanks, but I think we should avoid duplicating GUI code like that. The code should refactored to keep the frame-type specific code separate, called via hooks by generic code, and generic code should not be in xfns.c, w32fns.c etc., but in general platform-independent source file, such as window.c.