From: Eli Zaretskii <eliz@gnu.org>
To: Rajeev Narang <rajeev@sivalik.com>
Cc: emacs-devel@gnu.org
Subject: Re: icalendar.el bug fix patch
Date: Fri, 01 Nov 2019 11:40:04 +0200 [thread overview]
Message-ID: <83eeyslytn.fsf@gnu.org> (raw)
In-Reply-To: <875zkfd1rz.fsf@hm.sivalik.com> (emacs-devel@gnu.org)
> Date: Wed, 23 Oct 2019 09:33:52 -0400
> From: Rajeev Narang via "Emacs development discussions." <emacs-devel@gnu.org>
>
> icalendar-export-region does not export multi-line Desc as it is imported by icalendar-import-file. The following patch fixes the issue. If acceptable, please commit. Thanks.
>
> diff --git a/lisp/calendar/icalendar.el b/lisp/calendar/icalendar.el
> index 1186ced3fb..1f4e582aa5 100644
> --- a/lisp/calendar/icalendar.el
> +++ b/lisp/calendar/icalendar.el
> @@ -1244,7 +1244,7 @@ icalendar--parse-summary-and-rest
> (concat "\\(" icalendar-import-format-uid "\\)??"))))
> ;; Need the \' regexp in order to detect multi-line items
> (setq s (concat "\\`"
> - (replace-regexp-in-string "%s" "\\(.*?\\)" s nil t)
> + (replace-regexp-in-string "%s" "\\([^z-a]*?\\)" s nil t)
> "\\'"))
Thanks, but is [^a-z] correct? Do you want to reject only lower-case
ASCII characters? What about non-ASCII?
next prev parent reply other threads:[~2019-11-01 9:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 13:33 icalendar.el bug fix patch Rajeev Narang via Emacs development discussions.
2019-11-01 9:40 ` Eli Zaretskii [this message]
2019-11-01 10:51 ` Mattias Engdegård
2019-11-01 13:00 ` Eli Zaretskii
2019-11-01 11:12 ` Rajeev Narang via Emacs development discussions.
2019-11-01 13:05 ` Eli Zaretskii
2019-11-01 13:24 ` Mattias Engdegård
2019-11-01 13:33 ` Eli Zaretskii
2019-11-01 21:19 ` Paul Eggert
2019-11-01 21:38 ` Mattias Engdegård
2019-11-02 18:39 ` Juri Linkov
2019-11-03 13:21 ` Richard Stallman
2019-11-03 16:55 ` Drew Adams
2019-11-03 19:55 ` Stefan Monnier
2019-11-03 20:54 ` Juri Linkov
2019-11-03 21:10 ` Stefan Monnier
2019-11-03 21:32 ` Juri Linkov
[not found] ` <E81C3456-834F-469D-B8CA-80B1CDD311F8@acm.org>
2019-11-04 0:50 ` Paul Eggert
2019-11-04 11:56 ` Mattias Engdegård
2019-11-04 15:16 ` Drew Adams
2019-11-03 3:24 ` Richard Stallman
2019-11-03 16:54 ` Drew Adams
2019-11-01 16:44 ` Howard Melman
2019-11-01 14:30 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83eeyslytn.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rajeev@sivalik.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).