From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-tree-sitter and Emacs Date: Mon, 30 Mar 2020 16:07:35 +0300 Message-ID: <83eeta3sa0.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="25465"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Jorge Javier Araya Navarro Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 30 15:08:07 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jIu99-0006WO-3z for ged-emacs-devel@m.gmane-mx.org; Mon, 30 Mar 2020 15:08:07 +0200 Original-Received: from localhost ([::1]:49476 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIu98-0002Qs-2d for ged-emacs-devel@m.gmane-mx.org; Mon, 30 Mar 2020 09:08:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44477) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIu8W-0001Py-LQ for emacs-devel@gnu.org; Mon, 30 Mar 2020 09:07:29 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43551) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jIu8W-0003vg-Gj; Mon, 30 Mar 2020 09:07:28 -0400 Original-Received: from [176.228.60.248] (port=4123 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jIu8T-000408-RE; Mon, 30 Mar 2020 09:07:26 -0400 In-Reply-To: (message from Jorge Javier Araya Navarro on Sun, 29 Mar 2020 21:23:49 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:246000 Archived-At: > From: Jorge Javier Araya Navarro > Date: Sun, 29 Mar 2020 21:23:49 -0600 > > I have gone through th0rex's pull request[2] and nothing suggests that hooks are being used in order to do > the fontification of buffers, the only hook we have is `tree-sitter--after-change', it does re-parsing and keeps > the tree updated Can you explain why an after-change hook is at all needed? Why not pass to tree-sitter the chunk that jit-lock is going to fontify? AFAIU, tree-sitter is well suited for parsing incomplete source chunks. OTOH, using an after-change hook has its downsides, even if disregard slow-down (which I wouldn't).