From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Reliable after-change-functions (via: Using incremental parsing in Emacs) Date: Tue, 31 Mar 2020 18:58:58 +0300 Message-ID: <83eet81pod.fsf@gnu.org> References: <83o8sf3r7i.fsf@gnu.org> <2E218879-0F24-4A20-B210-263C8D0BEEA4@gmail.com> <87o8sdn0ot.fsf@gmail.com> <09E90C25-6119-44D4-85F2-A9CC4196FFE4@gmail.com> <83a73x3bh1.fsf@gnu.org> <87y2rhkwhk.fsf@gmail.com> <83zhbw1x7f.fsf@gnu.org> <87tv24lk8a.fsf@gmail.com> <83mu7w1tkc.fsf@gnu.org> <87pncsleml.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="23299"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, emacs-devel@gnu.org, monnier@iro.umontreal.ca, akrl@sdf.org To: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 31 17:59:18 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jJJIL-0005xM-Up for ged-emacs-devel@m.gmane-mx.org; Tue, 31 Mar 2020 17:59:17 +0200 Original-Received: from localhost ([::1]:40856 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJJIL-0002Md-0V for ged-emacs-devel@m.gmane-mx.org; Tue, 31 Mar 2020 11:59:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39198) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJJHr-0001y1-3c for emacs-devel@gnu.org; Tue, 31 Mar 2020 11:58:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41522) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jJJHq-0005dz-JW; Tue, 31 Mar 2020 11:58:46 -0400 Original-Received: from [176.228.60.248] (port=3383 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jJJHp-0005ZG-Gw; Tue, 31 Mar 2020 11:58:46 -0400 In-Reply-To: <87pncsleml.fsf@gmail.com> (message from =?utf-8?B?xaB0xJtw?= =?utf-8?B?w6FuIE7Em21lYw==?= on Tue, 31 Mar 2020 17:37:22 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:246116 Archived-At: > From: Štěpán Němec > Cc: casouri@gmail.com, akrl@sdf.org, monnier@iro.umontreal.ca, > emacs-devel@gnu.org > Date: Tue, 31 Mar 2020 17:37:22 +0200 > > Another attempt attached. Thanks. I have a couple of minor nits: > +@strong{Warning:} You should only bind this variable for modifications I'd prefer to remove the warning, and say "We recommend that..." rather than "You should only...". > +To delay change hooks during a series of changes, use > +`combine-change-calls' or `combine-after-change-calls' instead of > +modifying this variable. ^^^^^^^^^ "binding" Other than that, LGTM.