From: Eli Zaretskii <eliz@gnu.org>
To: "Nicolas Bértolo" <nicolasbertolo@gmail.com>
Cc: emacs-devel@gnu.org, akrl@sdf.org
Subject: Re: [PATCH] [WIP] Port feature/native-comp to Windows.
Date: Tue, 12 May 2020 19:56:55 +0300 [thread overview]
Message-ID: <83eerp852g.fsf@gnu.org> (raw)
In-Reply-To: <CAFnS-OkT=x1Ni8jwVRJRWVTRYVEKgK1uqpePws2G2HzTgAPf9A@mail.gmail.com> (message from Nicolas Bértolo on Mon, 11 May 2020 23:46:09 -0300)
> From: Nicolas Bértolo <nicolasbertolo@gmail.com>
> Date: Mon, 11 May 2020 23:46:09 -0300
> Cc: Andrea Corallo <akrl@sdf.org>, emacs-devel@gnu.org
>
> The attached patch does implement dynamic loading of libgccjit in Windows.
Thanks.
> - LIBGCCJIT_LIB="-lgccjit -ldl"
> + # mingw32 loads the library dynamically.
> + if test "${opsys}" != "mingw32"; then
> + LIBGCCJIT_LIB="-lgccjit -ldl"
libdl exists only in MinGW64, I think.
Why do you need it? is it because the code uses dlopen/dlsym
somewhere?
> +/* In alphabetical order */
> +#define gcc_jit_block_add_assignment fn_gcc_jit_block_add_assignment
> +#define gcc_jit_block_add_comment fn_gcc_jit_block_add_comment
> +#define gcc_jit_block_add_eval fn_gcc_jit_block_add_eval
> +#define gcc_jit_block_end_with_conditional fn_gcc_jit_block_end_with_conditional
I think it's good to #undef each symbol before defining it.
next prev parent reply other threads:[~2020-05-12 16:56 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 19:55 [PATCH] [WIP] Port feature/native-comp to Windows Nicolas Bertolo
2020-05-08 22:00 ` Andrea Corallo
2020-05-08 22:11 ` Nicolas Bértolo
2020-05-08 22:22 ` Andrea Corallo
2020-05-08 22:23 ` Nicolas Bértolo
2020-05-08 22:27 ` Andrea Corallo
2020-05-08 23:18 ` Stefan Monnier
2020-05-09 6:07 ` Eli Zaretskii
2020-05-09 15:28 ` Nicolas Bértolo
2020-05-09 15:48 ` Eli Zaretskii
2020-05-09 17:09 ` Andrea Corallo
2020-05-10 16:36 ` Nicolas Bértolo
2020-05-10 17:08 ` Eli Zaretskii
2020-05-10 17:50 ` Nicolas Bértolo
2020-05-10 18:22 ` Eli Zaretskii
2020-05-10 19:02 ` Nicolas Bértolo
2020-05-10 19:16 ` Eli Zaretskii
2020-05-10 19:41 ` Nicolas Bértolo
2020-05-10 19:50 ` Andrea Corallo
2020-05-10 19:55 ` Nicolas Bértolo
2020-05-10 20:01 ` Andrea Corallo
2020-05-11 14:19 ` Eli Zaretskii
2020-05-11 14:17 ` Eli Zaretskii
2020-05-11 15:20 ` Nicolas Bértolo
2020-05-11 16:19 ` Eli Zaretskii
2020-05-11 16:43 ` Andrea Corallo
2020-05-11 16:44 ` Nicolas Bértolo
2020-05-11 17:05 ` Eli Zaretskii
2020-05-11 18:19 ` Fabrice Popineau
2020-05-11 18:37 ` Andrea Corallo
2020-05-11 18:48 ` Eli Zaretskii
2020-05-11 19:27 ` Stefan Monnier
2020-05-11 19:42 ` Fabrice Popineau
2020-05-12 2:46 ` Nicolas Bértolo
2020-05-12 16:56 ` Eli Zaretskii [this message]
2020-05-12 17:25 ` Nicolas Bértolo
2020-05-12 18:21 ` Andrea Corallo
2020-05-12 20:33 ` Andrea Corallo
2020-05-13 14:09 ` Nicolas Bértolo
2020-05-13 14:31 ` Andrea Corallo
2020-05-13 15:00 ` Nicolas Bértolo
2020-05-13 15:17 ` Andrea Corallo
2020-05-13 15:48 ` Eli Zaretskii
2020-05-13 3:59 ` Richard Stallman
2020-05-13 14:02 ` Nicolas Bértolo
2020-05-13 15:23 ` Eli Zaretskii
2020-05-13 14:52 ` Eli Zaretskii
2020-05-10 19:47 ` Andrea Corallo
2020-05-10 19:39 ` Andrea Corallo
2020-05-10 17:13 ` Andrea Corallo
2020-05-10 17:15 ` Eli Zaretskii
2020-05-10 18:14 ` Andrea Corallo
2020-05-10 18:30 ` Eli Zaretskii
2020-05-10 18:54 ` Andrea Corallo
2020-05-10 19:02 ` Eli Zaretskii
2020-05-10 19:07 ` Nicolas Bértolo
2020-05-10 19:14 ` Andrea Corallo
2020-05-10 19:24 ` Andrea Corallo
2020-05-10 19:30 ` Eli Zaretskii
2020-05-10 18:05 ` Nicolas Bértolo
2020-05-10 18:23 ` Andrea Corallo
2020-05-10 17:20 ` Andrea Corallo
2020-05-09 13:42 ` Andrea Corallo
2020-05-09 15:40 ` Nicolas Bértolo
2020-05-09 15:55 ` Eli Zaretskii
2020-05-09 16:07 ` Nicolas Bértolo
2020-05-09 16:15 ` Eli Zaretskii
2020-05-09 16:27 ` Andrea Corallo
2020-05-09 16:33 ` Eli Zaretskii
2020-05-09 16:46 ` Andrea Corallo
2020-05-09 16:52 ` Andrea Corallo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83eerp852g.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=akrl@sdf.org \
--cc=emacs-devel@gnu.org \
--cc=nicolasbertolo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).