From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: mouse-face and help echo support for xterm mouse Date: Wed, 04 Nov 2020 20:51:02 +0200 Message-ID: <83eel9arc9.fsf@gnu.org> References: <31ff05295c806c4596c54fdcc8994a5f@finder.org> <3e7e0f6d1e272d03913e97254b2eabff@finder.org> <83imalazw7.fsf@gnu.org> <5928a03c79bcf0afee270de1df4d9fa5@finder.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2226"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jared@finder.org, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 04 19:56:32 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kaNxQ-0000UD-Rw for ged-emacs-devel@m.gmane-mx.org; Wed, 04 Nov 2020 19:56:32 +0100 Original-Received: from localhost ([::1]:48144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kaNxP-0008UA-SB for ged-emacs-devel@m.gmane-mx.org; Wed, 04 Nov 2020 13:56:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54436) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaNsD-0007vN-DC for emacs-devel@gnu.org; Wed, 04 Nov 2020 13:51:09 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45068) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kaNsC-0003Kt-5F; Wed, 04 Nov 2020 13:51:08 -0500 Original-Received: from [176.228.60.248] (port=4188 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kaNsB-0000fT-8q; Wed, 04 Nov 2020 13:51:07 -0500 In-Reply-To: (message from Stefan Monnier on Wed, 04 Nov 2020 13:47:29 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258693 Archived-At: > From: Stefan Monnier > Cc: Eli Zaretskii , emacs-devel@gnu.org > Date: Wed, 04 Nov 2020 13:47:29 -0500 > > `gpm_hold_quit->kind` could hold a different value from `NO_EVENT` on the > second iteration (and subsequent ones) of the loop. > > > Because it is the first time passed, we can safely deduce that > > hold_quit->kind will still be NO_EVENT *unless* a previous loop iteration > > changed it. > > That's right. > > > Because it is the only time passed, we can safely deduce that > > hold_quit->kind can only changed in a previous loop iteration by this > > function storing a quit event. However, this can not happen. hold_quit > > would get set by kbd_buffer_store_buffered_event which > > kbd_buffer_store_event_hold calls. To get set, the following must all be > > true: > > > > 1. An event of kind ASCII_KEYSTROKE_EVENT must be processed. > > 2. And that event's character code must be quit_char. > > 3. And that event must be on the current frame's KBOARD (not quite sure what > > this means). > > > > However, 1 will never be true as the only events that ever reach this point > > are of kind GPM_CLICK_EVENT, as deduced from the above asserts. > > Oh, I see, indeed. Are you guys taking into consideration the fact that this is a TTY, where C-g causes a SIGINT, so it can come in at any time?