unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: jared@finder.org, emacs-devel@gnu.org
Subject: Re: mouse-face and help echo support for xterm mouse
Date: Wed, 04 Nov 2020 20:51:02 +0200	[thread overview]
Message-ID: <83eel9arc9.fsf@gnu.org> (raw)
In-Reply-To: <jwvk0v1ngcc.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Wed, 04 Nov 2020 13:47:29 -0500)

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Eli Zaretskii <eliz@gnu.org>,  emacs-devel@gnu.org
> Date: Wed, 04 Nov 2020 13:47:29 -0500
> 
> `gpm_hold_quit->kind` could hold a different value from `NO_EVENT` on the
> second iteration (and subsequent ones) of the loop.
> 
> > Because it is the first time passed, we can safely deduce that
> >  hold_quit->kind will still be NO_EVENT *unless* a previous loop iteration
> > changed it.
> 
> That's right.
> 
> > Because it is the only time passed, we can safely deduce that
> >  hold_quit->kind can only changed in a previous loop iteration by this
> >  function storing a quit event.  However, this can not happen.  hold_quit
> >  would get set by kbd_buffer_store_buffered_event which
> >  kbd_buffer_store_event_hold calls.  To get set, the following must all be
> > true:
> >
> > 1. An event of kind ASCII_KEYSTROKE_EVENT must be processed.
> > 2. And that event's character code must be quit_char.
> > 3. And that event must be on the current frame's KBOARD (not quite sure what
> >   this means).
> >
> > However, 1 will never be true as the only events that ever reach this point
> > are of kind GPM_CLICK_EVENT, as deduced from the above asserts.
> 
> Oh, I see, indeed.

Are you guys taking into consideration the fact that this is a TTY,
where C-g causes a SIGINT, so it can come in at any time?



  reply	other threads:[~2020-11-04 18:51 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-01  5:46 mouse-face and help echo support for xterm mouse Jared Finder via Emacs development discussions.
2020-11-01 13:39 ` Stefan Monnier
2020-11-01 15:56   ` Jared Finder via Emacs development discussions.
2020-11-04  6:54     ` Jared Finder via Emacs development discussions.
2020-11-04 14:13       ` Stefan Monnier
2020-11-04 15:46         ` Eli Zaretskii
2020-11-04 15:56           ` Stefan Monnier
2020-11-04 17:54             ` Jared Finder via Emacs development discussions.
2020-11-04 18:47               ` Stefan Monnier
2020-11-04 18:51                 ` Eli Zaretskii [this message]
2020-11-04 19:05                   ` Stefan Monnier
2020-11-04 19:10                     ` Jared Finder via Emacs development discussions.
2020-11-04 15:19       ` Eli Zaretskii
2020-11-05  8:15   ` Jared Finder via Emacs development discussions.
2020-11-05 14:45     ` Stefan Monnier
2020-11-05 19:58       ` Jared Finder via Emacs development discussions.
2020-11-05 20:18         ` Stefan Monnier
2020-11-06  5:23           ` Jared Finder via Emacs development discussions.
2020-11-06  6:00             ` Eli Zaretskii
2020-11-06  6:46               ` Jared Finder via Emacs development discussions.
2020-11-06  7:39                 ` Eli Zaretskii
2020-11-07  1:22                   ` Jared Finder via Emacs development discussions.
2020-11-14 12:38                     ` Eli Zaretskii
2020-11-14 12:35                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83eel9arc9.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=jared@finder.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).