From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH 09/10] Access buffer_defaults in BVAR if there's no
 local binding
Date: Thu, 19 Nov 2020 20:21:27 +0200
Message-ID: <83eekpnr6g.fsf@gnu.org>
References: <87mtzil519.fsf@catern.com>
 <20201119153814.17541-10-sbaugh@catern.com>
 <jwva6vd6y5r.fsf-monnier+emacs@gnu.org>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="29397"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: sbaugh@catern.com, arnold@tdrhq.com, emacs-devel@gnu.org, dgutov@yandex.ru
To: Stefan Monnier <monnier@iro.umontreal.ca>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 19 19:23:02 2020
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1kfoaE-0007Zf-MS
	for ged-emacs-devel@m.gmane-mx.org; Thu, 19 Nov 2020 19:23:02 +0100
Original-Received: from localhost ([::1]:60510 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1kfoaD-0004jk-ML
	for ged-emacs-devel@m.gmane-mx.org; Thu, 19 Nov 2020 13:23:01 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56838)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1kfoYz-0003rZ-9g
 for emacs-devel@gnu.org; Thu, 19 Nov 2020 13:21:45 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58765)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1kfoYy-00026n-6N; Thu, 19 Nov 2020 13:21:44 -0500
Original-Received: from [176.228.60.248] (port=4882 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1kfoYw-0004uU-NP; Thu, 19 Nov 2020 13:21:43 -0500
In-Reply-To: <jwva6vd6y5r.fsf-monnier+emacs@gnu.org> (message from Stefan
 Monnier on Thu, 19 Nov 2020 13:08:16 -0500)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:259447
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/259447>

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Thu, 19 Nov 2020 13:08:16 -0500
> Cc: Arnold Noronha <arnold@tdrhq.com>, Dmitry Gutov <dgutov@yandex.ru>,
>  emacs-devel@gnu.org
> 
> Your patch series will also presumably slow down BVAR access to the
> other fields since they need to test `SHOULD_USE_BUFFER_DEFAULTS` now,
> but I think this is the price to pay.  It should be negligible for
> accesses to those vars from Elisp code, but of the 600 or so uses of
> BVAR in the current code, I wonder if some of them could show
> a measurable speed penalty.

There are 85 uses of BVAR in xdisp.c, something to look into, I guess.