unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: alan@idiocy.org, emacs-devel@gnu.org
Subject: Re: master 5dd2d50: Fix NS native compilation builds
Date: Sat, 26 Jun 2021 14:25:43 +0300	[thread overview]
Message-ID: <83eecorhoo.fsf@gnu.org> (raw)
In-Reply-To: <87fsx4dgh1.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat,  26 Jun 2021 13:15:38 +0200)

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Sat, 26 Jun 2021 13:15:38 +0200
> Cc: Alan Third <alan@idiocy.org>
> 
> alan@idiocy.org (Alan Third) writes:
> 
> > +# A NextStep style app bundle is relocatable, so instead of
> > +# hard-coding paths try to generate them at run-time.
> > +#
> > +# The paths are mostly the same, and the bundle paths are different
> > +# between macOS and GNUstep, so just replace any references to the app
> > +# bundle root itself with the relative path.
> > +epaths-force-ns-self-contained: epaths-force
> > +	@(sed < ${srcdir}/src/epaths.h > epaths.h.$$$$	\
> > +	  -e 's;${ns_appdir}/;;') &&			\
> > +	${srcdir}/build-aux/move-if-change epaths.h.$$$$ src/epaths.h
> 
> This (or something else in this patch) leads to the src/epaths.h file
> being invalid.  It starts like this:
> 
> * Hey Emacs, this is -*- C -*- code!  */
> *
> Copyright (C) 1993, 1995, 1997, 1999, 2001-2021 Free Software
> Foundation, Inc.
> 
> This file is part of GNU Emacs.
> 
> 
> Note the * instead of /* as the comment starter.

I think this is because EN_NS_SELF_CONTAINED ends up being "yes" on
systems where it shouldn't.



  reply	other threads:[~2021-06-26 11:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210626093722.32209.46548@vcs0.savannah.gnu.org>
     [not found] ` <20210626093724.2934420D0A@vcs0.savannah.gnu.org>
2021-06-26 11:15   ` master 5dd2d50: Fix NS native compilation builds Lars Ingebrigtsen
2021-06-26 11:25     ` Eli Zaretskii [this message]
2021-06-26 11:42       ` Alan Third
2021-06-26 11:45         ` Lars Ingebrigtsen
2021-06-26 11:49           ` Alan Third

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83eecorhoo.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=alan@idiocy.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).