From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Silence checkdoc for symbols designating major and minor modes
Date: Wed, 28 Jul 2021 19:08:48 +0300
Message-ID: <83eebito8f.fsf@gnu.org>
References: <87k0lbfmto.fsf@posteo.net> <83tukeu0zl.fsf@gnu.org>
 <87fsvyfqce.fsf@posteo.net>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="12236"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: Philip Kaludercic <philipk@posteo.net>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jul 28 18:09:25 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1m8m7Z-0002yg-Ni
	for ged-emacs-devel@m.gmane-mx.org; Wed, 28 Jul 2021 18:09:25 +0200
Original-Received: from localhost ([::1]:60734 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1m8m7Y-0001am-7z
	for ged-emacs-devel@m.gmane-mx.org; Wed, 28 Jul 2021 12:09:24 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56294)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1m8m73-0000uL-K6
 for emacs-devel@gnu.org; Wed, 28 Jul 2021 12:08:53 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59776)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1m8m73-0001r7-12; Wed, 28 Jul 2021 12:08:53 -0400
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2574
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1m8m72-0001dS-Ko; Wed, 28 Jul 2021 12:08:52 -0400
In-Reply-To: <87fsvyfqce.fsf@posteo.net> (message from Philip Kaludercic on
 Wed, 28 Jul 2021 14:46:57 +0000)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:271760
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/271760>

> From: Philip Kaludercic <philipk@posteo.net>
> Cc: emacs-devel@gnu.org
> Date: Wed, 28 Jul 2021 14:46:57 +0000
> 
>         (defcustom rcirc-omit-responses
>           '("JOIN" "PART" "QUIT" "NICK")
>           "Responses which will be hidden when `rcirc-omit-mode' is enabled."
>           :type '(repeat string))
> 
> triggering this response:
> 
>         Disambiguate rcirc-omit-mode by preceding w/ function,command,variable,option or symbol.

FWIW, I think this warning should be removed wholesale.  It is too
harsh to require such finesses in doc strings.

But if we want to keep it, I think we should include in the regexp
also the "enabled" and "disabled" part that follows it.  Just
exempting "-mode" sounds too general for a heuristic.