From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: PR: dired-do-create-files now checks for trailing slashes in the target Date: Wed, 29 Sep 2021 16:09:48 +0300 Message-ID: <83ee97il43.fsf@gnu.org> References: <831r58k0cx.fsf@gnu.org> <87tui4qyni.fsf@gnu.org> <83tui4iift.fsf@gnu.org> <874ka43rp1.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21752"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rudiwillalwaysloveyou@gmail.com, stefankangas@gmail.com, emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 29 15:29:49 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mVZee-0005QI-Hb for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Sep 2021 15:29:48 +0200 Original-Received: from localhost ([::1]:57872 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVZed-0001ky-Dn for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Sep 2021 09:29:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40346) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVZLC-000421-LC for emacs-devel@gnu.org; Wed, 29 Sep 2021 09:09:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55924) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVZLC-00087A-DG; Wed, 29 Sep 2021 09:09:42 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1448 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVZLB-00034n-Tt; Wed, 29 Sep 2021 09:09:42 -0400 In-Reply-To: <874ka43rp1.fsf@gnu.org> (message from Tassilo Horn on Wed, 29 Sep 2021 06:46:04 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275789 Archived-At: > From: Tassilo Horn > Cc: rudiwillalwaysloveyou@gmail.com, stefankangas@gmail.com, > emacs-devel@gnu.org > Date: Wed, 29 Sep 2021 06:46:04 +0200 > > > So the behavior will now differ depending on whether new_name already > > exists or not? > > Right. And also `dired-create-destination-dirs' has to be non-nil for > the new behavior which conforms to its documentation. I have that set > to 'ask, and when I apply Rudi's patch and do the recipe, it'll ask if a > new directory new_name/ should be created. > > > because if the user types > > > > R /new_ TAB > > > > Emacs will complete it to "/new_name/", including the trailing slash. > > But only if it exists, and then the patch makes no difference in > behavior. Isn't that exactly the problem? If both old_name and new_name exist, how do I rename old_name into new_name so that it overwrites new_name instead of becoming its subdirectory? I must carefully type new_name RET so as to avoid having a slash at its end. I would support such a change only if it had an explicit defcustom to control it. (It could be a new value of dired-create-destination-dirs, if that makes sense.)