From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master c9cb59b 2/2: * etc/TODO: Entry about converting to defvar-keymap. Date: Fri, 10 Dec 2021 18:51:40 +0200 Message-ID: <83ee6ks8rn.fsf@gnu.org> References: <83ilvwsdxg.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13551"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 10 17:53:08 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mvj8t-0003Jx-Vd for ged-emacs-devel@m.gmane-mx.org; Fri, 10 Dec 2021 17:53:07 +0100 Original-Received: from localhost ([::1]:55004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mvj8t-00051q-08 for ged-emacs-devel@m.gmane-mx.org; Fri, 10 Dec 2021 11:53:07 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36160) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvj7h-00042J-Qz for emacs-devel@gnu.org; Fri, 10 Dec 2021 11:51:53 -0500 Original-Received: from [2001:470:142:3::e] (port=34752 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvj7h-00032I-IJ; Fri, 10 Dec 2021 11:51:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Y3gist6iGb19sPy7P3LwaV27pP/960e8yhDB8btdK2k=; b=R3qKEZQquigm BokyXL7+g6vaaj89CeonEiRfbalauKR+j2Sdv7gWX6HWlfI5ckurC4fEfvbrJtOV9wATV9DEQJ43G OMz4uWuj+EmjeCJ7VQn3QFjLLgRDQJYlFunpUymAYNF1x26jhurSSa9Q3MdRM5BupCkJfgiEl7QSn +uBm7FnDxX0ZVOyHKmWSNijPF/TIXknKf10tJjOwQH3YeWao5XldpYrmHLfYTlAJFkhHnFEiwKbpi fPcPRNN2RUcGkLUwp9+KAkMVXOcPESTiIQmz67owKVw+8SMbIXLWyu23C4sPLE7FnHoCsnemLQp7C WcPtOxHD16sVMApXdyiejg==; Original-Received: from [87.69.77.57] (port=1383 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvj7h-0000Gp-D4; Fri, 10 Dec 2021 11:51:53 -0500 In-Reply-To: (message from Stefan Kangas on Fri, 10 Dec 2021 15:37:32 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:281607 Archived-At: > From: Stefan Kangas > Date: Fri, 10 Dec 2021 15:37:32 +0000 > Cc: emacs-devel@gnu.org > > Eli Zaretskii writes: > > >> +** Convert defvar foo-mode-map to defvar-keymap > >> +Verify the conversion by comparing the value of the keymap before > >> +converting it and after (you can see the value in 'C-h v'). > > > > Really? What are the benefits of doing such a conversion? I see only > > a lot of code churn and a risk of breaking things that are perfectly > > fine as they are. > > I think this is a good entry-level exercise for someone who is looking > to start contributing to Emacs. I think it shouldn't be done, not by beginners, not by anyone. > Please feel free to revert it if you disagree. I will, unless Lars disagrees. > > And that goes for many of the changes in this direction you made > > lately, btw: why are we making all those changes for purely stylistic > > reasons? > > Yes, I'm not making any friends doing that, am I? :-) > > Personally, I do such things when I don't have the time or energy to > invest in anything significant. I can come up with other ways to > procrastinate, of course. Can I convince you to do more useful things when that happens? How about reading a random section in the manual, or a random set of doc strings, and making them more clear?